Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbcDZGTI (ORCPT ); Tue, 26 Apr 2016 02:19:08 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33978 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbcDZGTF (ORCPT ); Tue, 26 Apr 2016 02:19:05 -0400 Date: Tue, 26 Apr 2016 00:18:52 -0600 From: Brian Norris To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, David Woodhouse , Greg Ungerer , linux-mtd@lists.infradead.org Subject: Re: [PATCH] drivers/mtd: make maps/uclinux.c driver more explicitly non-modular Message-ID: <20160426061852.GC25981@localhost> References: <1459095234-20386-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459095234-20386-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 27 On Sun, Mar 27, 2016 at 12:13:54PM -0400, Paul Gortmaker wrote: > The Kconfig for this support is currently declared with: > > config MTD_UCLINUX > bool "Generic uClinux RAM/ROM filesystem support" > > ...meaning that it currently is not being built as a module by anyone. > Lets remove as much of the modular evidence that we can, so that when > reading the driver there is less doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also replace module.h with moduleparam.h since the file does use > a module_param, and leaving it as such is currently the easiest way > to remain compatible with existing boot arg use cases. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: David Woodhouse > Cc: Brian Norris > Cc: Greg Ungerer > Cc: linux-mtd@lists.infradead.org > Signed-off-by: Paul Gortmaker Applied to l2-mtd.git