Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273AbcDZGjf (ORCPT ); Tue, 26 Apr 2016 02:39:35 -0400 Received: from mga09.intel.com ([134.134.136.24]:39459 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbcDZGje convert rfc822-to-8bit (ORCPT ); Tue, 26 Apr 2016 02:39:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,535,1455004800"; d="scan'208";a="792447808" From: "Zhang, Yanmin" To: Afzal Mohammed , "Zhang, LongX" CC: "mingo@redhat.com" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] sched: don't output cpu sched info by default Thread-Topic: [PATCH] sched: don't output cpu sched info by default Thread-Index: AQHRnq4y1Y2Dq4Qho0Cdyg6VBLQKkZ+Z/OYAgAFzvmCAAF1koA== Date: Tue, 26 Apr 2016 06:39:03 +0000 Message-ID: <144086DDB7BB6D429C79280EB1C804D40AB769CD@SHSMSX103.ccr.corp.intel.com> References: <571DA569.5040701@intel.com> <20160425104948.GA4637@afzalpc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 49 I double-check it. Function show_state_filter chooses to print all tasks when state_filter == 0 (TASK_RUNNING). sysrq_sched_debug_show prints per cpu sched debug info. They are different info. It is better to use sched_debug_enabled to control the 2nd part output. Yanmin -----Original Message----- From: Zhang, Yanmin Sent: Tuesday, April 26, 2016 9:04 AM To: Afzal Mohammed; Zhang, LongX Cc: mingo@redhat.com; peterz@infradead.org; linux-kernel@vger.kernel.org Subject: RE: [PATCH] sched: don't output cpu sched info by default Thanks for the pointer. We didn't notice that. That patch also fixes the issue indeed. Yanmin -----Original Message----- From: Afzal Mohammed [mailto:afzal.mohd.ma@gmail.com] Sent: Monday, April 25, 2016 6:50 PM To: Zhang, LongX Cc: mingo@redhat.com; peterz@infradead.org; linux-kernel@vger.kernel.org; Zhang, Yanmin Subject: Re: [PATCH] sched: don't output cpu sched info by default Hi, On Mon, Apr 25, 2016 at 01:04:41PM +0800, Zhang Long wrote: > Android userspace debug prcoess might dump system info by sysrq. > One info is of cpu sched. Usually, one thread has one line dump. > Such log is huge sometimes and such dumping spends lots of time and > make the system worse. Sometimes, watchdog resets the system in the > end. > > The patch fixes it by dumping cpu sched info only when > sched_debug_enabled is true. Doesn't "sched: don't dump sched debug info in SysRq-W" currently in tip/sched/core help ?, http://lkml.kernel.org/r/1459777322-30902-1-git-send-email-rabin.vincent@axis.com Regards afzal