Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752296AbcDZG56 (ORCPT ); Tue, 26 Apr 2016 02:57:58 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38543 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbcDZG54 (ORCPT ); Tue, 26 Apr 2016 02:57:56 -0400 Date: Tue, 26 Apr 2016 07:57:55 +0100 From: Lee Jones To: Tomeu Vizoso Cc: Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Sameer Nanda , Javier Martinez Canillas , Benson Leung , Enric =?iso-8859-1?Q?Balletb=F2?= , Vic Yang , Stephen Boyd , Vincent Palatin , Randall Spangler , Todd Broch , Gwendal Grignou , Vic Yang , linux-input@vger.kernel.org Subject: Re: [PATCH v8 2/7] Input: cros_ec_keyb - Stop handling interrupts directly Message-ID: <20160426065755.GA19037@dell> References: <1460464350-30414-1-git-send-email-tomeu.vizoso@collabora.com> <1460464350-30414-3-git-send-email-tomeu.vizoso@collabora.com> <20160425211735.GG26059@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 31 On Tue, 26 Apr 2016, Tomeu Vizoso wrote: > On 25 April 2016 at 23:17, Dmitry Torokhov wrote: > > On Tue, Apr 12, 2016 at 02:32:25PM +0200, Tomeu Vizoso wrote: > >> From: Vic Yang > >> > >> Because events other that keyboard ones will be handled by now on by > >> other drivers, stop directly handling interrupts and instead listen to > >> the new notifier in the MFD driver. > >> > > > > Hmm, where did Vic's sign-off go? > > Lee Jones asked to remove them in a previous version as he considers > them superfluous. My understanding is that as I'm the first to submit > them to mainline, the chain starts with me (I certify the b section of > http://developercertificate.org/). Hmm... It seems what I said has been misconstrued a little. You *should* remove SoBs from people who were *only* part of the submission path. However, you should *not* remove SoBs from patch *authors*. Since Vic is the author (or at least one of them), their SoB should remain. Apologies if that was not clear. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog