MIME-Version: 1.0
In-Reply-To: <20160426065755.GA19037@dell>
References: <1460464350-30414-1-git-send-email-tomeu.vizoso@collabora.com>
 <1460464350-30414-3-git-send-email-tomeu.vizoso@collabora.com>
 <20160425211735.GG26059@dtor-ws> <CAAObsKC3+Fw2QBKnur5ZYWw=Ys4yQaoEYdXV+cjNjGYyyO5McQ@mail.gmail.com>
 <20160426065755.GA19037@dell>
From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Date: Tue, 26 Apr 2016 09:06:21 +0200
Message-ID: <CAAObsKC2RrLZ4t9jPigxt4asquf1hjumWAb6h9iH8tHqU2cdPA@mail.gmail.com>
Subject: Re: [PATCH v8 2/7] Input: cros_ec_keyb - Stop handling interrupts directly
To: Lee Jones <lee.jones@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sameer Nanda <snanda@chromium.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Benson Leung <bleung@chromium.org>,
        =?UTF-8?Q?Enric_Balletb=C3=B2?= <enric.balletbo@collabora.co.uk>,
        Vic Yang <victoryang@chromium.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Vincent Palatin <vpalatin@chromium.org>,
        Randall Spangler <rspangler@chromium.org>,
        Todd Broch <tbroch@chromium.org>,
        Gwendal Grignou <gwendal@chromium.org>,
        Vic Yang <victoryang@google.com>, linux-input@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1213
Lines: 32

On 26 April 2016 at 08:57, Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 26 Apr 2016, Tomeu Vizoso wrote:
>
>> On 25 April 2016 at 23:17, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>> > On Tue, Apr 12, 2016 at 02:32:25PM +0200, Tomeu Vizoso wrote:
>> >> From: Vic Yang <victoryang@google.com>
>> >>
>> >> Because events other that keyboard ones will be handled by now on by
>> >> other drivers, stop directly handling interrupts and instead listen to
>> >> the new notifier in the MFD driver.
>> >>
>> >
>> > Hmm, where did Vic's sign-off go?
>>
>> Lee Jones asked to remove them in a previous version as he considers
>> them superfluous. My understanding is that as I'm the first to submit
>> them to mainline, the chain starts with me (I certify the b section of
>> http://developercertificate.org/).
>
> Hmm... It seems what I said has been misconstrued a little.  You
> *should* remove SoBs from people who were *only* part of the
> submission path.  However, you should *not* remove SoBs from patch
> *authors*.  Since Vic is the author (or at least one of them), their
> SoB should remain.
>
> Apologies if that was not clear.

I see now, will fix the tags in the next revision.

Thanks,

Tomeu