Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbcDZJGQ (ORCPT ); Tue, 26 Apr 2016 05:06:16 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:39280 "EHLO e19.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896AbcDZJE5 (ORCPT ); Tue, 26 Apr 2016 05:04:57 -0400 X-IBM-Helo: d01dlp02.pok.ibm.com X-IBM-MailFrom: ravi.bangoria@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [RFC] perf probe: Fix module probe issue if no dwarf support To: Masami Hiramatsu References: <1461580708-15169-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1461580708-15169-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20160426062925.9dbfda280af62f077a27e297@kernel.org> Cc: linux-kernel@vger.kernel.org, acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, masami.hiramatsu.pt@hitachi.com, wangnan0@huawei.com, namhyung@kernel.org, srikar@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com From: Ravi Bangoria Message-ID: <571F2F28.50000@linux.vnet.ibm.com> Date: Tue, 26 Apr 2016 14:34:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160426062925.9dbfda280af62f077a27e297@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042609-0057-0000-0000-000004259AA7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 53 On Tuesday 26 April 2016 02:59 AM, Masami Hiramatsu wrote: > On Mon, 25 Apr 2016 16:08:28 +0530 > Ravi Bangoria wrote: > >> Perf is not able to register probe in kernel module when dwarf supprt >> is not there(and so it goes for symtab). Perf passes full path of >> module where only module name is required which is causing the problem. >> This patch fixes this issue. >> >> Before applying patch: >> >> $ dpkg -s libdw-dev >> dpkg-query: package 'libdw-dev' is not installed ... >> >> $ ./perf probe -m /linux/samples/kobject/kobject-example.ko foo_show >> Added new event: >> probe:foo_show (on foo_show in /linux/samples/kobject/kobject-example.ko) >> >> You can now use it in all perf tools, such as: >> >> perf record -e probe:foo_show -aR sleep 1 >> >> $ cat /sys/kernel/debug/tracing/kprobe_events >> p:probe/foo_show /linux/samples/kobject/kobject-example.ko:foo_show >> >> After applying patch: >> >> $ ./perf probe -m /linux/samples/kobject/kobject-example.ko foo_show >> Added new event: >> probe:foo_show (on foo_show in kobject_example) >> >> You can now use it in all perf tools, such as: >> >> perf record -e probe:foo_show -aR sleep 1 >> >> $ cat /sys/kernel/debug/tracing/kprobe_events >> p:probe/foo_show kobject_example:foo_show >> > Looks good to me :) > However, it seems that this patch depends on your previous patch > ("perf probe: Fix offline module name missmatch issue") > In that case, could you make these a series of patches? > > Acked-by: Masami Hiramatsu Thanks Masami, I've sent v2 with changes you suggested. Please review it. Regards, Ravi