Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751993AbcDZJmJ (ORCPT ); Tue, 26 Apr 2016 05:42:09 -0400 Received: from mail.visioncatalog.com ([217.6.246.34]:47194 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbcDZJmH (ORCPT ); Tue, 26 Apr 2016 05:42:07 -0400 Subject: Re: [PATCH] regulator: rk808: remove unused rk808_reg_ops_ranges To: Arnd Bergmann , Mark Brown References: <1461662378-1879912-1-git-send-email-arnd@arndb.de> Cc: Liam Girdwood , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Doug Anderson , Chris Zhong , linux-kernel@vger.kernel.org From: Wadim Egorov Message-ID: <571F37D3.8010102@phytec.de> Date: Tue, 26 Apr 2016 11:41:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461662378-1879912-1-git-send-email-arnd@arndb.de> X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 26.04.2016 11:41:39, Serialize by Router on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 26.04.2016 11:41:39, Serialize complete at 26.04.2016 11:41:39 X-TNEFEvaluated: 1 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=windows-1252 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2457 Lines: 67 Sorry for that. I missed to add rk808_reg_ops_ranges in the LDO_REG3 desc in patch afcd666d9db0 On 26.04.2016 11:19, Arnd Bergmann wrote: > After removing all uses of the range operations in a recent patch, > we get a warning about the symbol not being referenced anywhere: > > drivers/regulator/rk808-regulator.c:306:29: 'rk808_reg_ops_ranges' defined but not used > > This removes the now-unused structure along with the > rk808_set_suspend_voltage_range function that is only referenced from > rk808_reg_ops_ranges. > > Signed-off-by: Arnd Bergmann > Fixes: afcd666d9db0 ("regulator: rk808: remove linear range definitions with a single range") > --- > drivers/regulator/rk808-regulator.c | 28 ---------------------------- > 1 file changed, 28 deletions(-) > > diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c > index 964b95eed271..67f72feed815 100644 > --- a/drivers/regulator/rk808-regulator.c > +++ b/drivers/regulator/rk808-regulator.c > @@ -238,21 +238,6 @@ static int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv) > sel); > } > > -static int rk808_set_suspend_voltage_range(struct regulator_dev *rdev, int uv) > -{ > - unsigned int reg; > - int sel = regulator_map_voltage_linear_range(rdev, uv, uv); > - > - if (sel < 0) > - return -EINVAL; > - > - reg = rdev->desc->vsel_reg + RK808_SLP_REG_OFFSET; > - > - return regmap_update_bits(rdev->regmap, reg, > - rdev->desc->vsel_mask, > - sel); > -} > - > static int rk808_set_suspend_enable(struct regulator_dev *rdev) > { > unsigned int reg; > @@ -303,19 +288,6 @@ static struct regulator_ops rk808_reg_ops = { > .set_suspend_disable = rk808_set_suspend_disable, > }; > > -static struct regulator_ops rk808_reg_ops_ranges = { > - .list_voltage = regulator_list_voltage_linear_range, > - .map_voltage = regulator_map_voltage_linear_range, > - .get_voltage_sel = regulator_get_voltage_sel_regmap, > - .set_voltage_sel = regulator_set_voltage_sel_regmap, > - .enable = regulator_enable_regmap, > - .disable = regulator_disable_regmap, > - .is_enabled = regulator_is_enabled_regmap, > - .set_suspend_voltage = rk808_set_suspend_voltage_range, > - .set_suspend_enable = rk808_set_suspend_enable, > - .set_suspend_disable = rk808_set_suspend_disable, > -}; > - > static struct regulator_ops rk808_switch_ops = { > .enable = regulator_enable_regmap, > .disable = regulator_disable_regmap,