Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752489AbcDZKrU (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Apr 2016 06:47:20 -0400
Received: from canardo.mork.no ([148.122.252.1]:37265 "EHLO canardo.mork.no"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751082AbcDZKrS convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Apr 2016 06:47:18 -0400
From: =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
To: Ingo Molnar <mingo@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@alien8.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg
Organization: m
References: <20160425145606.598329f2@gandalf.local.home>
	<20160425190651.GL3448@twins.programming.kicks-ass.net>
	<CA+55aFzKP4N0xSZGF4kkTcK7iOyAmOK+CR1B=DfD8=TsN0qnEA@mail.gmail.com>
	<20160425154405.59522c6d@gandalf.local.home>
	<20160426053647.GA21680@gmail.com>
Date: Tue, 26 Apr 2016 12:43:49 +0200
In-Reply-To: <20160426053647.GA21680@gmail.com> (Ingo Molnar's message of
	"Tue, 26 Apr 2016 07:36:47 +0200")
Message-ID: <871t5svee2.fsf@nemi.mork.no>
User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 944
Lines: 28

Ingo Molnar <mingo@kernel.org> writes:

>  static int parse_proc_cmdline_item(const char *key, const char *value) {
>
>         /*
>          * The systemd.log_xyz= settings are parsed by all tools, and
>          * so is "debug".
>          *
>          * However, "quiet" is only parsed by PID 1, and only turns of
>          * status output to /dev/console, but does not alter the log
>          * level.
>          */
>
>         if (streq(key, "debug") && !value)
>                 log_set_max_level(LOG_DEBUG);
>
>         else if (streq(key, "systemd.log_target") && value) {
>
> Why systemd does this fully knowing that other software (such as the kernel) 
> already uses 'debug', while systemd already has the 'system.*' parameter namespace 
> is left up to the reader...

A couple of links to save that reader from making futile comments:
https://lkml.org/lkml/2014/4/2/415
https://bugs.freedesktop.org/show_bug.cgi?id=76935


Bjørn