Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbcDZLJ3 (ORCPT ); Tue, 26 Apr 2016 07:09:29 -0400 Received: from merlin.infradead.org ([205.233.59.134]:44146 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752568AbcDZLJZ (ORCPT ); Tue, 26 Apr 2016 07:09:25 -0400 Date: Tue, 26 Apr 2016 13:09:05 +0200 From: Peter Zijlstra To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Ingo Molnar , Steven Rostedt , Linus Torvalds , LKML , Borislav Petkov , Greg Kroah-Hartman , Andrew Morton , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Message-ID: <20160426110905.GR3448@twins.programming.kicks-ass.net> References: <20160425145606.598329f2@gandalf.local.home> <20160425190651.GL3448@twins.programming.kicks-ass.net> <20160425154405.59522c6d@gandalf.local.home> <20160426053647.GA21680@gmail.com> <871t5svee2.fsf@nemi.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <871t5svee2.fsf@nemi.mork.no> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 31 On Tue, Apr 26, 2016 at 12:43:49PM +0200, Bj?rn Mork wrote: > Ingo Molnar writes: > > > static int parse_proc_cmdline_item(const char *key, const char *value) { > > > > /* > > * The systemd.log_xyz= settings are parsed by all tools, and > > * so is "debug". > > * > > * However, "quiet" is only parsed by PID 1, and only turns of > > * status output to /dev/console, but does not alter the log > > * level. > > */ > > > > if (streq(key, "debug") && !value) > > log_set_max_level(LOG_DEBUG); > > > > else if (streq(key, "systemd.log_target") && value) { > > > > Why systemd does this fully knowing that other software (such as the kernel) > > already uses 'debug', while systemd already has the 'system.*' parameter namespace > > is left up to the reader... > > A couple of links to save that reader from making futile comments: > https://lkml.org/lkml/2014/4/2/415 > https://bugs.freedesktop.org/show_bug.cgi?id=76935 Thanks for providing the links, I did remember all that. Its one of the many reasons why I recommend against running systemd(isease).