Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752077AbcDZMdc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Apr 2016 08:33:32 -0400
Received: from mail-am1on0133.outbound.protection.outlook.com ([157.56.112.133]:30398
	"EHLO emea01-am1-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1751363AbcDZMd3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Apr 2016 08:33:29 -0400
Authentication-Results: vger.kernel.org; dkim=none (message not signed)
 header.d=none;vger.kernel.org; dmarc=none action=none
 header.from=gomspace.com;
Subject: Re: [PATCH 3/3] rtc: add Cypress FM33256B RTC driver
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
References: <1461150471-23163-1-git-send-email-jlp@gomspace.com>
 <1461150471-23163-4-git-send-email-jlp@gomspace.com>
 <20160421234400.GG29844@piout.net>
CC: <lee.jones@linaro.org>, <arnd@arndb.de>, <gregkh@linuxfoundation.org>,
        <a.zummo@towertech.it>, <robh+dt@kernel.org>, <pawel.moll@arm.com>,
        <mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
        <galak@codeaurora.org>, <rtc-linux@googlegroups.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Jeppe Ledet-Pedersen <jlp@gomspace.com>
Message-ID: <571F5C56.9080209@gomspace.com>
Date: Tue, 26 Apr 2016 14:17:26 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <20160421234400.GG29844@piout.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [77.243.61.136]
X-ClientProxiedBy: AM2PR03CA0017.eurprd03.prod.outlook.com
 (2a01:111:e400:8414::27) To DB3PR04MB0635.eurprd04.prod.outlook.com
 (2a01:111:e400:9431::21)
X-MS-Office365-Filtering-Correlation-Id: 1f9506b6-3c3e-4c70-0940-08d36dcceac4
X-Microsoft-Exchange-Diagnostics: 1;DB3PR04MB0635;2:ocM2pbjCnXWedq0z2QrzAH74+mHdbOeE0NkjpxqnWsWo499UVynT5C75qj6VniO1wULYSCGlms/y42J42UtPcZz4gol9jrAQ+sAbaCoYjRNsjGvgzYEFyqa5KeNmqDkuSmNQkpsR5vrV68q0rnY5yGa7uNc5m4TDQFkEsSr+EC4g1N8UWNWwvXFsQCgL/x8S;3:mRM2776dIYijChDrWaR/nhDqDXTrDN7TJVN/Xk4cmQLjaXeJPPt6mc2ABw7ogPerWJ5bR//wyq5+RVHx+DCZx8yarSaQ0TL2Y/OvKlgdlxpAchDsAUmDMGCRNS8ts0XW;25:/pTNJt/xnOSewzx5KXgEshCWT3E0qs9Wpu2juKlrzGkmT4B9yfsv0561Yomn+C8JHSD3E9syOqxSyiCD2qH5lWsfvu6SsvfiTJnE+DPha59X9zFQtuhsjvXCJuUgq5vFy6FKkRh0n89cOIO7lPzZChUfLaO26SWDjtE0oYz6s8ixkmRdQ2b8iDXHU8Fic9WeGnS4OCQh3MNgRzwv0/HJpGtZ7R5ljZZ4CnDsqGodHPx1jHiuK9N7dLyO35bJaWPpMiUduDJTMVekdeH3sasl5YcVIT5V78fII6NX1Y8SY2iwZFd96twEhO0b4IaB4oi5CNmQJfW5Nu/9pkhezh/bNA==
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR04MB0635;
X-Microsoft-Exchange-Diagnostics: 1;DB3PR04MB0635;20:nsDuqT/8GQ+Luq2tpFLV79CTrBUFCboviGV1NELBr52RdK5szlaVjqS+lQ1nQ7RhGBlTWOxG9w/jDm9BOa4skR8RrBYcRwGgJY3jhbWPo6nYF2uuLOYrnex5O79JZaYWa+lniegDfmQ/uPLDxqUUj53e01wdlK47jm3CbwLcAyWe0JE9Bbw4iGf9d3ZQ48BCTiK87nmL9OHg49nEFxdY0hCnuXysp747HP1yWqG9lS7VEZCNV1+7KceUtydj6EjPw9FERCGlZu8YUEPtjL8P0qCwolHlRRBMkBSOEm3YofJZZUuBbRuzvZXYbkgrJwOBmksWXfnP8Hp+KZs2WK/TFcXTFlvkXzJuYOnux5COal7+9kjj+HSMVnUWzw2i38Kvx20PkE9C+ce6UC8uaT2xxL6etRp99rox8Rld++11+HKCU7VWy7flDETNg+7Upngn;4:nJ2v3dlN8ElnTeWj2m+MZ8Ie57WsE2U5v9WdWb+ZJaw4EL6capZe84V8PCS9hjE0tYDzR+89nYK8gDrCXbaGjdHneYAMuJ9/5hi16g9zzHOObttsBBRlD0fjrEovVlRXeU28gahQXGyai1pOkppLrPtzEJV8GSZWFe1lTU2f9pxJypiUqGORKqACRe9uT1tJsjMkP6Orpdo3npoYX3jqOFdrrfP1K+IqvXwaDUBOBGPH6H5BbUVv7eSrqrKAvfZcMh1v4N8VTv0mkeQX9WR8hMYyHyQZ28G2FLsLvUWTc9jpbBA1V9h9x/38J8/zcRVgBX7WXauvVgu+S0hr6+5UOa/QdVSKsjMLMQF7yAMlx9GyyM58BVg8blU2zJrTi5Na1n2sqAUiE94B1XHf3/+NxXYXG4lqjyP22jocUHhZA0C72zK8q4pt1hmaYPNjOENy4kfCYz4yAEPbWcsu7X4JYw==
X-Microsoft-Antispam-PRVS: <DB3PR04MB0635AD4409A7CABB388D9DA1C2630@DB3PR04MB0635.eurprd04.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521072)(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:DB3PR04MB0635;BCL:0;PCL:0;RULEID:;SRVR:DB3PR04MB0635;
X-Forefront-PRVS: 0924C6A0D5
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(24454002)(51914003)(86362001)(81166005)(558084003)(66066001)(65956001)(47776003)(59896002)(50466002)(64126003)(83506001)(23746002)(1096002)(50986999)(3846002)(2906002)(65816999)(230700001)(110136002)(87266999)(76176999)(54356999)(92566002)(33656002)(36756003)(5008740100001)(189998001)(42186005)(4326007)(586003)(80316001)(4001350100001)(6116002)(5004730100002)(2950100001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB3PR04MB0635;H:Jeppes-MacBook-Pro.local;FPR:;SPF:None;MLV:sfv;LANG:en;
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB3PR04MB0635;23:u6L13Pr9zQctBnJLulTcER6oFAkO8CvLeyiWJ?=
 =?Windows-1252?Q?z+YOHMdJQSZFC7KGd8Vt9dvlgwZodG8JNfnNw/W/f3UPxoq5Av+fHDaF?=
 =?Windows-1252?Q?ZfjZSHDtn7czBFFHcv+hV9LckdNRM9FF2oYMVQWtdSXI94BUfM91aiHF?=
 =?Windows-1252?Q?oySIq0O4eeOXgQa64cGGms47aOUYSpFv7DMlMSPRBop3DSxXgFpOLcdU?=
 =?Windows-1252?Q?ohH9avvECPyik/wkGHLGfVCLpXka/anoBq09CTDNrkJdOWsM1Wb2Snew?=
 =?Windows-1252?Q?0bkRailxEgNUU/D3bKY1DMh2S1bhcgcpmQ6K70Naqj/gVmBNM+xsyuFz?=
 =?Windows-1252?Q?GgpNih0CRmv0cQAPoKGCNgUGX7WCmjOAsKp78oWgYJybdftQmez43aK3?=
 =?Windows-1252?Q?mhwJlFFwuVRnjqxRpsRfe/Pv9wfU2oL2AOYwvM/KPVLiKIhhlHIbf1/o?=
 =?Windows-1252?Q?ixNzPtfp1MShJipbdwlpRfKOjgDB5fjh7j1HyZgNVVco37YPGx3Q7lXA?=
 =?Windows-1252?Q?2hHcYkTOTRXQrem6frVQI2nV8PvLGOhq3bQB/aefbMKmZEc74CQzhky/?=
 =?Windows-1252?Q?IF/pQ8pc9R5AaFUXZDYIghyTc9keNuDsAIqePRHM1iNVQ0JOPqMq2Xs3?=
 =?Windows-1252?Q?Q5+kGk6BAScvAQSRbXQomHMpCmZqsTY6SuFD/yLz7lctcN26GMGfTPl0?=
 =?Windows-1252?Q?aNJZ7yCsk12nHz0CxnCjD/rJ1TyFefnUnyPaHiAeaS/ID7uJB7A9Febc?=
 =?Windows-1252?Q?nVb5pQNLGKoU+PqF5F/i5u/yVrO7mVG8224ft2xM/31iLCvVSfQL5yKl?=
 =?Windows-1252?Q?RYJigvMdybRixaGrNcgfJU+oZZhcp8jp/zwKiMhd86t6y69JTlOQQ+MW?=
 =?Windows-1252?Q?vUA3bke6KygQDF7u5Tk4GoCvokHeyDuHJUUZ09Z+XXmYIwl62+AdHFoc?=
 =?Windows-1252?Q?25RgCslp27Zj9C0PHNZtWBlYU7NOP+z9qmrQYJJY6ve5ZZaE1yYaaWmN?=
 =?Windows-1252?Q?W6vmimMcBJeDOgNPrOF+WKQUDN8a3Wu7aH66rjOK040a8BuRws73u4wk?=
 =?Windows-1252?Q?w0tVXeZ0+BeQawtciORm8ymeVP64yT8Cwcn?=
X-Microsoft-Exchange-Diagnostics: 1;DB3PR04MB0635;5:hNdQTBgE3Crm938kRzTd7LKWEDltyrbEOIjJg9vKFTq7g4cE+4Fixl3hclxg6B1OFuA16gHVKdMjVEAMSUGrERCVMFEextdXi8tbhX4R3jfFDSkFPFLzJE95mtJ06+kg01oDEIYBUsnuqbgsLy9FbQ==;24:e8XUzkNM+sp1G0J9Gf6+tBsYEw+0EQOZoxoECrnuyR5lVaMagE9C/dAcAYA/aHv7Z+RoG+nbJtkEhJYW/1WR9Vl8B06WsIZ97LUENX6wUXc=
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: gomspace.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2016 12:18:46.1187 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR04MB0635
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 181
Lines: 10

On 22/04/16 01:44, Alexandre Belloni wrote:
> Hi,

Hi Alexandre,

> Looks mostly good, a few comments below

Thanks for the review. I'll add your fixes and send a v2 patch.

-Jeppe