Date: Tue, 26 Apr 2016 16:01:56 +0300
From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: "J.D. Schroeder" <Linux.HWI@garmin.com>
Cc: linux-kernel@vger.kernel.org, peter.ujfalusi@ti.com, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
        Jim Lodes <jim.lodes@garmin.com>,
        "J.D. Schroeder" <jay.schroeder@garmin.com>
Subject: Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration
Message-ID: <20160426130156.GA15388@bitmer.com>
References: <1461600607-19582-1-git-send-email-Linux.HWI@garmin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461600607-19582-1-git-send-email-Linux.HWI@garmin.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1048
Lines: 29

On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
> 
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
> 
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
>  sound/soc/omap/omap-pcm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
>  	struct dma_chan *chan;
>  	int err = 0;
>  
> +	memset(&config, 0x00, sizeof(config));

Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")

Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>