Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbcDZNwl (ORCPT ); Tue, 26 Apr 2016 09:52:41 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:33431 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbcDZNwj (ORCPT ); Tue, 26 Apr 2016 09:52:39 -0400 MIME-Version: 1.0 In-Reply-To: <1461117257-27048-1-git-send-email-andrew@aj.id.au> References: <1461117257-27048-1-git-send-email-andrew@aj.id.au> Date: Tue, 26 Apr 2016 15:52:38 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl-exynos5440: Use off-stack memory for pinctrl_gpio_range From: Linus Walleij To: Andrew Jeffery Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Kukjin Kim , Thomas P Abraham , linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 21 On Wed, Apr 20, 2016 at 3:54 AM, Andrew Jeffery wrote: > The range is registered into a linked list which can be referenced > throughout the lifetime of the driver. Ensure the range's memory is useful > for the same lifetime by adding it to the driver's private data structure. > > The bug was introduced in the driver's initial commit, which was present in > v3.10. > > Signed-off-by: Andrew Jeffery > Fixes: f0b9a7e521fa ("pinctrl: exynos5440: add pinctrl driver for Samsung EXYNOS5440 SoC") > Cc: stable@vger.kernel.org > --- > Since v1: > > * Add range member kerneldoc addressing Tomasz Figa's comment Patch applied with the ACKs. Yours, Linus Walleij