Date: Tue, 26 Apr 2016 11:07:42 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Subject: Re: [PATCH perf/core v4 04/19] perf: Add lsdir to read a directory
Message-ID: <20160426140742.GC11033@kernel.org>
References: <20160426090200.11891.43944.stgit@devbox>
 <20160426090242.11891.79014.stgit@devbox>
 <20160426134020.GB31483@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160426134020.GB31483@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1113
Lines: 26

Em Tue, Apr 26, 2016 at 10:40:20AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Apr 26, 2016 at 06:02:42PM +0900, Masami Hiramatsu escreveu:
> > From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> > 
> > As a utility function, add lsdir() which reads given
> > directory and store entry name into a strlist.
> > lsdir accepts a filter function so that user can
> > filter out unneeded entries.
> > 
> > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> Thanks, applied.

Had to fix it to build on some distros, like ubuntu 12.04:

alldeps-ubuntu-12.04: FAIL
util/util.h:228:38: error: declaration of 'dirname' shadows a global declaration [-Werror=shadow]
cc1: all warnings being treated as errors
mv: cannot stat `/tmp/build/perf/util/.db-export.o.tmp': No such file or directory
make[3]: *** [/tmp/build/perf/util/db-export.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [util] Error 2
make[2]: *** [ui] Error 2
make[1]: *** [/tmp/build/perf/libperf-in.o] Error 2
make: *** [install-bin] Error 2