Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752454AbcDZOg3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Apr 2016 10:36:29 -0400
Received: from h2.hallyn.com ([78.46.35.8]:54818 "EHLO h2.hallyn.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751845AbcDZOgZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Apr 2016 10:36:25 -0400
Date: Tue, 26 Apr 2016 09:36:23 -0500
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Karel Zak <kzak@redhat.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
        linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        containers@lists.linux-foundation.org, hannes@cmpxchg.org,
        gregkh@linuxfoundation.org, tj@kernel.org, cgroups@vger.kernel.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup
Message-ID: <20160426143622.GA11021@mail.hallyn.com>
References: <1460923472-29370-1-git-send-email-serge.hallyn@ubuntu.com>
 <1460923472-29370-3-git-send-email-serge.hallyn@ubuntu.com>
 <20160418041126.GA424@mail.hallyn.com>
 <87mvoqqu48.fsf@x220.int.ebiederm.org>
 <20160419014419.GA19080@mail.hallyn.com>
 <20160419040546.GA20350@mail.hallyn.com>
 <20160426024207.GA2783@mail.hallyn.com>
 <20160426102925.vkydkjtrsnibuc7c@ws.net.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160426102925.vkydkjtrsnibuc7c@ws.net.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1819
Lines: 34

On Tue, Apr 26, 2016 at 12:29:25PM +0200, Karel Zak wrote:
> On Mon, Apr 25, 2016 at 09:42:07PM -0500, Serge E. Hallyn wrote:
> > > Looking at it another way...  The value we're talking about shows us
> > > the path of the root dentry of a cgroup mount.  If a task in cgns2
> > > rooted at /a/b/c mounts a cgroupfs, it will see '/' as the root dentry.
> > > If a task in cgns1 rooted at /a/b looks at that mountinfo, '/' would
> > > be misleading.  It really should be '/c'.
> > 
> > So I think that for cgroup mount entries in mountinfo to be useful (i.e.
> > to criu) we either need the root dentry path to be given as relative to
> > the reader's cgroup namespace (as I have it in this patchset), or else
> > we need to add another piece of information in the mountinfo entry, such
> > as the nsfd inode number of the cgroup namespace in which it was
> > mounted.
> 
> In the ideal world there is no mountinfo file, but /proc/self/mountinfo/<id>/
> directory with individual files, so every subsystem and filesystem has 
> absolute freedom to store there all relevant information. The result will 
> be also lucky kernel that does not have to always generate entire huge 
> mountinfo file for all mountpoins... etc. :-)

Yeah mountinfo does seem like a big stick to swing around every time I want
one little piece of information.  Also mght be good to have per-fstype
directories so we can just look under /proc/self/mountsdir/cgroupfs/ for
only cgroupfs <id>s.

There we might also find open fds for source and mountdir, kinda fitting
in with previous discussions of separating bdev_open() and mountat().

BTW, assuming this would in fact report source and mountpoint location
with fds, these would really (through realpath) be reported relative to
the reader's namespace, as I'm doing and advocating here.

-serge