Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbcDZOsC (ORCPT ); Tue, 26 Apr 2016 10:48:02 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33544 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbcDZOsA (ORCPT ); Tue, 26 Apr 2016 10:48:00 -0400 Subject: Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_CA822138-4333-403D-B0AA-786C04C4695C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.6b2 From: Parth Sane In-Reply-To: <571F7ED9.9060509@osg.samsung.com> Date: Tue, 26 Apr 2016 20:17:53 +0530 Cc: Greg KH , Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, amitoj1606@gmail.com, juliana.orod@gmail.com, "open list:STAGING SUBSYSTEM" , linux-kernel@vger.kernel.org Message-Id: <211132EC-6399-491B-852B-5A7F73A2DE00@gmail.com> References: <1461598998-28070-1-git-send-email-laerdevstudios@gmail.com> <571F7B93.1000903@osg.samsung.com> <81A80B1B-A2B4-44BC-A06D-9D74A2EA4A41@gmail.com> <571F7ED9.9060509@osg.samsung.com> To: Luis de Bethencourt X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2597 Lines: 85 --Apple-Mail=_CA822138-4333-403D-B0AA-786C04C4695C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 Hi, Yes you are right on that regard. I did do that in my previous patches. It=92s just something that I will have to remember now onwards. Thanks. Regards, Parth Sane > On 26-Apr-2016, at 8:14 PM, Luis de Bethencourt = wrote: >=20 > On 26/04/16 15:33, Parth Sane wrote: >> Hi, >> Thanks for the feedback. I did find this issue with the assistance = checkpatch.pl script. >> Regards, >> Parth Sane >=20 > Normally people mention the checkpatch warning they are fixing. >=20 > For example: > = https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id= =3D5f10ef7dce02d8e36665974aca0977cda58c1122 >=20 > Verbosity in the commit message is a good thing :) >=20 > I have tested that your patch still applies cleanly to Greg's = staging-testing branch. >=20 > Thanks, > Luis >=20 >>> On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt = wrote: >>>=20 >>> On 25/04/16 16:43, Parth Sane wrote: >>>> Fixed alignment to match open parenthesis. >>>>=20 >>>> Signed-off-by: Parth Sane >>>>=20 >>>> --- >>>> Changes in v6: >>>> -Added line before Signed-off message >>>>=20 >>>=20 >>> This last version looks good to me. Did you find this issue with = checkpatch.pl? >>>=20 >>> Thanks, >>> Luis >>>=20 >>=20 --Apple-Mail=_CA822138-4333-403D-B0AA-786C04C4695C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXH3+ZAAoJEOzxm4XTqyFixqAP/16JOG2Qxx65MNYN5gVWgaGN ybiH3if5xxMVQKvrgzyt+o9utjA00s1WZSIjKM8wuHMlmg9NrBOBWuTZmlmK1yHm CHm5/eQR4P3HcdpZuzXPaFwOQN0xTINNq6qrSKB7PF3B08bdD6K47BEGtgyCnhXn HlAGjW3M6d1Ia9RsGAx7IiXlT1+dogbnr9xuoCCtXLGxWrMZ2ZojGS+BDFyP4ijM OdJFKjXdxZT7+cvR6ijUwSc+adzr2EL7zxLdqWUK5aBUh+pDEHgeIJVNOvsypuCa z3nYfHquRlkT8dWV6314sdFGxcvLeltBnUpWFfOEvYs3qLfCFWWyKDJGBmpjIa9d GWf33H8uop0onHhSCAdjRo00eWjZxRPu/Dg8MSALaa5+aTbryZPgAoVzTOUoeEnG GFJ0AplQs/9Zz1Aec/oSaeGszgp/MbtHNgBaYkYEiaylLJtv2pdDVObjZN9iPs0h q15weopkMMnizDIyLmQfefVpEF9lRdJUVaIXv12/cM8Il87MCMMA5OQBSE+KQukX iqApkaEiHGQVHiybAAHr6MBQZShXqrHj9Oij9ItIogM8d2QAVRU0auP4UxToIT3T iW5LFH8J9/Lsa1TnMc4NoHbA3Q/9F1tzor4q0c4bzkHbYyiKDamNRjp3WbaAmJe0 4piOUQN4gZOqs5ge4sFh =oCsa -----END PGP SIGNATURE----- --Apple-Mail=_CA822138-4333-403D-B0AA-786C04C4695C--