Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752529AbcDZOtv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Apr 2016 10:49:51 -0400
Received: from iolanthe.rowland.org ([192.131.102.54]:59111 "HELO
	iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1751950AbcDZOtu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Apr 2016 10:49:50 -0400
Date: Tue, 26 Apr 2016 10:49:47 -0400 (EDT)
From: Alan Stern <stern@rowland.harvard.edu>
X-X-Sender: stern@iolanthe.rowland.org
To: Jiancheng Xue <xuejiancheng@hisilicon.com>
cc: linux-usb@vger.kernel.org, <linux-kernel@vger.kernel.org>,
        <yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>,
        <zhangzhenxing@hisilicon.com>, <suwenping@hisilicon.com>,
        <raojun@hisilicon.com>, <ml.yang@hisilicon.com>,
        <gaofei@hisilicon.com>, <hermit.wangheming@hisilicon.com>,
        <jiangheng@hisilicon.com>, <lpc.li@hisilicon.com>
Subject: Re: [PATCH] usb: ehci-platform: add reset controller number in struct
 ehci_platform_priv
In-Reply-To: <571EC16C.2050704@hisilicon.com>
Message-ID: <Pine.LNX.4.44L0.1604261048080.2038-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 457
Lines: 20

On Tue, 26 Apr 2016, Jiancheng Xue wrote:

> > If an error occurs here...
> > 
> Sorry. It's really a problem. I'll modify it in v2 like below:
> 
> err = reset_control_deassert(priv->rsts[rst]);
> if(err) {
> 	reset_control_put(priv->rsts[rst]);
> 	goto err_reset;
> }

Yes, that would be good.  (Except for the missing ' ' between "if" and 
"(".)

> Is it OK except this bug? If so, I'll send out v2 patch.

Everything else looked okay to me.

Alan Stern