Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbcDZOvm (ORCPT ); Tue, 26 Apr 2016 10:51:42 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36075 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbcDZOvj (ORCPT ); Tue, 26 Apr 2016 10:51:39 -0400 Date: Tue, 26 Apr 2016 15:51:29 +0100 From: Peter Griffin To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, vinod.koul@intel.com, lee.jones@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, ludovic.barre@st.com, arnaud.pouliquen@st.com Subject: Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs Message-ID: <20160426145129.GA11946@griffinp-ThinkPad-X1-Carbon-2nd> References: <1461236675-10176-1-git-send-email-peter.griffin@linaro.org> <1461236675-10176-11-git-send-email-peter.griffin@linaro.org> <20160421154933.GR3217@sirena.org.uk> <20160426115210.GB5457@griffinp-ThinkPad-X1-Carbon-2nd> <20160426142357.GW3217@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160426142357.GW3217@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 28 Hi Mark, On Tue, 26 Apr 2016, Mark Brown wrote: > On Tue, Apr 26, 2016 at 12:52:10PM +0100, Peter Griffin wrote: > > On Thu, 21 Apr 2016, Mark Brown wrote: > > > > This one is more relevant though I'm still a bit concerned that there's > > > an expectation that the examples can just be pasted in... > > > So although I would only consider copying an example as the starting > > point for getting something working (and indeed it was the case here). On STi > > arch there *should* be a very high probability that copying the exanple > > is all that will be required. > > If there are never going to be any new users why bother at all, why > would anyone paste it in when all the SoCs that ever use this are > already upstream? Generally if I come across documentation which is incorrect, I like to fix it. Currently the DT ASoC documentation doesn't match the driver and the example doesn't work, which is not ideal. I could well be the last person who needs to read it & use the example, but deliberately leaving it with mistakes in seemed like a bad idea. Peter.