Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbcDZPRx (ORCPT ); Tue, 26 Apr 2016 11:17:53 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:36674 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752229AbcDZPRv (ORCPT ); Tue, 26 Apr 2016 11:17:51 -0400 Date: Tue, 26 Apr 2016 11:17:47 -0400 (EDT) From: Nicolas Pitre To: Michal Marek cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 0/8]/[PULL REQUEST] Trim unused exported kernel symbols In-Reply-To: <571F2424.10907@suse.com> Message-ID: References: <57172CB2.1040801@suse.com> <571F2424.10907@suse.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2055 Lines: 58 On Tue, 26 Apr 2016, Michal Marek wrote: > On 2016-04-20 21:26, Nicolas Pitre wrote: > > On Wed, 20 Apr 2016, Nicolas Pitre wrote: > > > >> On Wed, 20 Apr 2016, Michal Marek wrote: > >> > >>> Dne 19.4.2016 v 05:32 Nicolas Pitre napsal(a): > >>>> Ping ! > >>>> > >>>> /me only hears back empty cave echoes ... > >>> > >>> Pulled now, sorry for the delay. > >> > >> Thanks! > > > > Looking at your kbuild branch, I see subsequent changes that require > > minor adjustments. Please merge the following patch: > > > > ----- >8 > > From a14d6e7a2902af78ee43ab075c7caf829fdfa4b2 Mon Sep 17 00:00:00 2001 > > From: Nicolas Pitre > > Date: Wed, 20 Apr 2016 15:16:01 -0400 > > Subject: [PATCH] kbuild: adjust ksym_dep_filter for some cmd renames > > > > The following renames occurred recently: > > > > cmd_cc_i_c --> cmd_cpp_i_c > > cmd_as_s_S --> cmd_cpp_s_S > > > > The respective cc_*_c and as_*_S patterns no longer match the above > > therefore additional patterns are needed. > > > > Signed-off-by: Nicolas Pitre > > > > diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include > > index a09927e027..bd6bd048cf 100644 > > --- a/scripts/Kbuild.include > > +++ b/scripts/Kbuild.include > > @@ -275,8 +275,10 @@ else > > flags_nodeps = $(filter-out -Wp$(comma)-M%, $($(1))) > > ksym_dep_filter = \ > > case "$(1)" in \ > > - cc_*_c) $(CPP) $(call flags_nodeps,c_flags) -D__KSYM_DEPS__ $< ;; \ > > - as_*_S) $(CPP) $(call flags_nodeps,a_flags) -D__KSYM_DEPS__ $< ;; \ > > + cc_*_c) $(CPP) $(call flags_nodeps,c_flags) -D__KSYM_DEPS__ $< ;; \ > > + as_*_S) $(CPP) $(call flags_nodeps,a_flags) -D__KSYM_DEPS__ $< ;; \ > > + cpp_i_c) $(CPP) $(call flags_nodeps,c_flags) -D__KSYM_DEPS__ $< ;; \ > > + cpp_s_S) $(CPP) $(call flags_nodeps,a_flags) -D__KSYM_DEPS__ $< ;; \ > > Please make it > cc_*_c | cpp_i_c) ... > as_*_S | cpp_s_S) ... Sure. Patch follows Nicolas