Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbcDZPSp (ORCPT ); Tue, 26 Apr 2016 11:18:45 -0400 Received: from relay2.sgi.com ([192.48.180.65]:50219 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750835AbcDZPSo (ORCPT ); Tue, 26 Apr 2016 11:18:44 -0400 Date: Tue, 26 Apr 2016 10:18:41 -0500 From: Alex Thorlton To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , LKML , Michal Hocko , Alex Thorlton , Vlastimil Babka Subject: Re: [PATCH 14/18] prctl: make PR_SET_THP_DISABLE wait for mmap_sem killable Message-ID: <20160426151841.GQ152091@stormcage.americas.sgi.com> References: <1461675385-5934-1-git-send-email-mhocko@kernel.org> <1461675385-5934-15-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461675385-5934-15-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 20 On Tue, Apr 26, 2016 at 02:56:21PM +0200, Michal Hocko wrote: > From: Michal Hocko > > PR_SET_THP_DISABLE requires mmap_sem for write. If the waiting > task gets killed by the oom killer it would block oom_reaper from > asynchronous address space reclaim and reduce the chances of timely OOM > resolving. Wait for the lock in the killable mode and return with EINTR > if the task got killed while waiting. > > Cc: Alex Thorlton > Acked-by: Vlastimil Babka > Signed-off-by: Michal Hocko Looks good to me - I wrote that bit of code so I think this can get an: Acked-by: Alex Thorlton Thanks for Ccing me! - Alex