Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbcDZPnc (ORCPT ); Tue, 26 Apr 2016 11:43:32 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45064 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbcDZPna (ORCPT ); Tue, 26 Apr 2016 11:43:30 -0400 Date: Tue, 26 Apr 2016 16:43:13 +0100 From: Mark Brown To: Andreas Dannenberg Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org Message-ID: <20160426154313.GA3217@sirena.org.uk> References: <1461615456-19510-1-git-send-email-dannenberg@ti.com> <1461615456-19510-3-git-send-email-dannenberg@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZMpvc8TwNEttvQ/F" Content-Disposition: inline In-Reply-To: <1461615456-19510-3-git-send-email-dannenberg@ti.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 52 --ZMpvc8TwNEttvQ/F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 25, 2016 at 03:17:36PM -0500, Andreas Dannenberg wrote: This looks mostly good, a few small things below. > + switch (width) { > + case 16: > + case 18: > + case 20: > + case 24: > + /* > + * We only support the different left-justified serial audio > + * formats in which case there is nothing to configure in the > + * TAS5720. > + */ > + break; > + default: > + dev_err(codec->dev, "unsupported sample size: %d\n", width); > + return -EINVAL; > + } If the driver doesn't do anything just remove the code. > + if ((curr_fault & TAS5720_OCE) && !(tas5720->last_fault & TAS5720_OCE)) > + dev_warn(dev, "The Class-D output stage has experienced an over current event\n"); "Class D over current". The verbosity is making the line over long and the phrasing is a bit unclear (and makes it seem less critical than it really is). These should probably be dev_crit() or somthing too, over current and similar events on a speaker output are generally extremely serious. --ZMpvc8TwNEttvQ/F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXH4yOAAoJECTWi3JdVIfQ904H/2N2DZLqJZYH3o7THlpyEftE HvgTXvCqQs6W2ynOTjbxeEv/06A/XaneaKaXdl8iGTKtWP/LwdAcADva4wtTsVts MQJuIOHIa4sUoXwKKA3Pru1REDNNkya7neeHczRmw4gl4EpfQ6s3pji4yPSAJ8Xl tM/YYDpPFCfTNXqFPN/MpQbS4rmeoB10nkpaeel5lszhJ2uk6uK/Ocav+UTCd+8Q EDZjLGkPuUEA9sO5S93Dr+AIimCD/sjycnQQDDDP43JmAZxlVOhgAuiDjr0y2ZJr 9jfaF/lU21PCCpy1RAjUObKzqWpkecptbr+wIOn/QtBUy0GWqERkPZTfX4iMS1E= =9yOJ -----END PGP SIGNATURE----- --ZMpvc8TwNEttvQ/F--