Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbcDZQlV (ORCPT ); Tue, 26 Apr 2016 12:41:21 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45228 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbcDZQlT (ORCPT ); Tue, 26 Apr 2016 12:41:19 -0400 Date: Tue, 26 Apr 2016 17:41:04 +0100 From: Mark Brown To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, vinod.koul@intel.com, lee.jones@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, ludovic.barre@st.com, arnaud.pouliquen@st.com Message-ID: <20160426164104.GC3217@sirena.org.uk> References: <1461236675-10176-1-git-send-email-peter.griffin@linaro.org> <1461236675-10176-11-git-send-email-peter.griffin@linaro.org> <20160421154933.GR3217@sirena.org.uk> <20160426115210.GB5457@griffinp-ThinkPad-X1-Carbon-2nd> <20160426142357.GW3217@sirena.org.uk> <20160426145129.GA11946@griffinp-ThinkPad-X1-Carbon-2nd> <20160426150319.GY3217@sirena.org.uk> <20160426161432.GA12088@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="79m9KipKW65BQbRT" Content-Disposition: inline In-Reply-To: <20160426161432.GA12088@griffinp-ThinkPad-X1-Carbon-2nd> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 46 --79m9KipKW65BQbRT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 26, 2016 at 05:14:32PM +0100, Peter Griffin wrote: > On Tue, 26 Apr 2016, Mark Brown wrote: > > A lot of this is details of the system integration for this SoC, not > > actual errors. > This particular clock patch yes, but the other ASoC dt doc update is fixing > bindings which haven't progressed in lockstep with the driver code. Presumably > this happened during the review process when they were changed to being st, > prefixed in the driver, but the doc wasn't also updated. The bits where you are correcting the names of the properties are not details of the system integration and are therefore fine. The bits where you're documenting the particular clocking arrangements for the SoC you happen to be using less so. > > it's fairly routine > > to have to explain to people that just because some old driver did > > something that doesn't mean it's something we want in new drivers. > I'm sure it is. Although I fail to see why leaving the documentation with > mistakes in is helpful to anybody. Fixing actual mistakes is fine. --79m9KipKW65BQbRT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXH5ofAAoJECTWi3JdVIfQZuYH/RfKp5QmiD+i+RpNev+dSIlp HBfag+AQCZMN5+wqHZ87r9dEy508WJPtQCViG9Fpglw/k+Otcj2JSt/T+HoCwl8L KY+5kkYUWAXeA7Ps8tR+a4RjXGsN23EThCheWlMsihqb1gljIDNI/AFFthU6pCD0 Lafx+xRDlSbkYyvChrC8521HQ0NsQU3CVKOlwRIfOy6eG3iHsWRGbEZFzKr7jm+Y YSdPUKIqBkrMKQPzU66+FJ4f3Q7fH04bBl3/xxFxHD600W7ii4vsej7EnrUvgHKB fySe1SBxO0n0q9N/r0+Br/sApBd6iGSUBH6ewVPOxf8OcleCdscZb978ClAzPj4= =OV1p -----END PGP SIGNATURE----- --79m9KipKW65BQbRT--