Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbcDZRBT (ORCPT ); Tue, 26 Apr 2016 13:01:19 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51621 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbcDZRBS (ORCPT ); Tue, 26 Apr 2016 13:01:18 -0400 Date: Tue, 26 Apr 2016 12:00:51 -0500 From: Andreas Dannenberg To: Mark Brown CC: , , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Subject: Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Message-ID: <20160426170051.GD2885@borg.dal.design.ti.com> References: <1461615456-19510-1-git-send-email-dannenberg@ti.com> <1461615456-19510-2-git-send-email-dannenberg@ti.com> <20160426153707.GZ3217@sirena.org.uk> <20160426161425.GA2885@borg.dal.design.ti.com> <20160426165006.GD3217@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160426165006.GD3217@sirena.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1703 Lines: 38 On Tue, Apr 26, 2016 at 05:50:06PM +0100, Mark Brown wrote: > On Tue, Apr 26, 2016 at 11:14:25AM -0500, Andreas Dannenberg wrote: > > On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote: > > > On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote: > > > > > +Optional properties: > > > > > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry > > > > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog > > > > This suggests that the device doesn't need power... > > > no power, now that would be nice! :) What this was supposed to mean is > > that the properties are optional, the power of course is not. The DT has > > They should only be optional if they may really be missing. We may > attempt to be liberal in the DTs we accept but we should not encourage > sloppily written DTs. Thanks for the guidance and the background. Will move them to "required" but I'll wait a few more days before re-submitting in case there is additional feedback on the patch series. Regards, Andreas > > > really no control over how I wire up my HW and I'd argue most folks just > > permanently power the TAS5720 since the shutdown current is just a few > > uAs IIRC in order to save some BOM cost. But I suppose the DT description > > is such that the Kernel can more intelligently handle things based on > > what the driver is doing if somebody choses and implements additional > > regulator/power switch HW. Or did I misunderstand your point? > > It doesn't really matter if a given system ends up controlling things > actively, we still want to be consistent in describing them since it is > less error prone when it does become relevant.