Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbcDZRXd (ORCPT ); Tue, 26 Apr 2016 13:23:33 -0400 Received: from mail-db3on0073.outbound.protection.outlook.com ([157.55.234.73]:11427 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751772AbcDZRXc convert rfc822-to-8bit (ORCPT ); Tue, 26 Apr 2016 13:23:32 -0400 From: Noam Camus To: David Miller CC: "linux-kernel@vger.kernel.org" , "abrodkin@synopsys.com" , Elad Kanfi , Tal Zilcer Subject: Re: [PATCH 0/3] Net driver bugs fix and code style Thread-Topic: [PATCH 0/3] Net driver bugs fix and code style Thread-Index: AQHRn45cLXbhjC+gAECBU4EkXXppY5+caa4AgAAVMfA= Date: Tue, 26 Apr 2016 17:23:26 +0000 Message-ID: References: <1461656126-22226-1-git-send-email-noamca@mellanox.com>,<20160426.115756.743073215803279443.davem@davemloft.net> In-Reply-To: <20160426.115756.743073215803279443.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [85.64.158.114] x-ms-office365-filtering-correlation-id: c5cac641-b84e-47bf-c041-08d36df77aca x-microsoft-exchange-diagnostics: 1;DB4PR05MB0830;5:fgtj/aZxleB62xhdnefsx5hGXYDDl8dz3r1eZXpmdc95qg3Uae21h85W9ojTNwJ6eqUHbjjq4YvfWjLo7PEeXjO30jrTZksaRKB9qJktDz/nakIKkxhf9yH+86wU7ofrYpWWEjaP1H51TXtbW6kh5Q==;24:EmBbOoQmCmkf/hokdbyJdQJrC2RVH9JC1xQ5o045PYw3ipjXeXQutzoRN+2ok1v0Yr1xEq7jgT0Ro8LeNBM5pv04XKl3oZr7DWQ7shxHj34=;7:D8mKsGz2ECCnZZgViHUnG52nvW+d3B+CAw8u/2TkbEHopWqJNn7PAdK05VpHRVUY2EuNHK90HSO3wvZRz1pZ3NqyBNkTtgcg819eS4OrHLPvgyLaFqKJnPnesqz50awV7Wn8hBAEo6iL9BsJoZS9wQvIk8TIcogWAfeGpIcs5ak= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR05MB0830; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB4PR05MB0830;BCL:0;PCL:0;RULEID:;SRVR:DB4PR05MB0830; x-forefront-prvs: 0924C6A0D5 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(87936001)(1220700001)(1096002)(81166005)(33656002)(11100500001)(189998001)(102836003)(76176999)(6116002)(54356999)(586003)(50986999)(92566002)(5003600100002)(9686002)(77096005)(5004730100002)(106116001)(5002640100001)(2906002)(10400500002)(122556002)(3846002)(74316001)(3280700002)(3660700001)(4326007)(19580395003)(5008740100001)(86362001)(19580405001)(2950100001)(2900100001)(66066001)(76576001)(4001430100002)(107886002)(110136002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR05MB0830;H:HE1PR05MB1625.eurprd05.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2016 17:23:26.8204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR05MB0830 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 527 Lines: 11 >From: David Miller >Sent: Tuesday, April 26, 2016 6:57 PM >It is not appropriate to mix coding style fixes with bug fixes. The code style in patch number 1 is actually prevents code duplication that stem from bug fix at patch number 3. >Bug fixes must be targetted at the 'net' tree, and anything else >must be targetted at the 'net-next' tree. Should we handle bugs fix first (more urgent then code style) and once it will be accepted and applied to net-next proceed with the code style patch? Noam