Subject: Re: [PATCH] block: partitions: efi: Always check for alternative GPT
 at end of drive
To: Davidlohr Bueso <dave@stgolabs.net>
References: <1461632806-5946-1-git-send-email-jwerner@chromium.org>
 <571F7D6D.8020209@gmail.com> <20160426181018.GA16601@linux-uzut.site>
Cc: Julius Werner <jwerner@chromium.org>, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        Gwendal Grignou <gwendal@chromium.org>,
        Doug Anderson <dianders@chromium.org>, Karel Zak <kzak@redhat.com>
From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
Message-ID: <571FC111.7020700@gmail.com>
Date: Tue, 26 Apr 2016 15:27:13 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <20160426181018.GA16601@linux-uzut.site>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 752
Lines: 14

On 2016-04-26 14:10, Davidlohr Bueso wrote:
> On Tue, 26 Apr 2016, Austin S. Hemmelgarn wrote:
>
>> At the absolute minimum, we should be logging (at least at a warning
>> level) that we had to fall back the the backup GPT.  If somebody is
>> dealing with a disk that had a torn write to the primary GPT, that's
>> one thing, but this could also be caused by any number of other
>> problems (hardware issues, malicious intent, etc), and we need to log
>> that we detected corrupted data.
>
> We already complain about corrupted primary gpt (at a warn level), and
> there's also plenty of verbosity about differences between primary and
> backup (see compare_gpts()), or are you referring to something else?
Ah, you're right, somehow I had missed this.