Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbcDZUNb (ORCPT ); Tue, 26 Apr 2016 16:13:31 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36544 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062AbcDZUN3 (ORCPT ); Tue, 26 Apr 2016 16:13:29 -0400 MIME-Version: 1.0 In-Reply-To: <721499bcaa3559f71023c6ab960481564f58f22a.1461656216.git.lv.zheng@intel.com> References: <721499bcaa3559f71023c6ab960481564f58f22a.1461656216.git.lv.zheng@intel.com> Date: Tue, 26 Apr 2016 22:13:27 +0200 X-Google-Sender-Auth: yRKgEu2_ZlBEfi-SFfR4g4VLZRU Message-ID: Subject: Re: [PATCH 3/4] ACPI / osi: Change default _OSI(Darwin) support From: "Rafael J. Wysocki" To: Lv Zheng Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Lv Zheng , Linux Kernel Mailing List , ACPI Devel Maling List , Chen Yu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 19 On Tue, Apr 26, 2016 at 9:40 AM, Lv Zheng wrote: > From: Chen Yu > > Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always > reports positive value when Apple hardware queries _OSI("Darwin"). However > since this implementation places the judgement in runtime, it breaks > acpi_osi=!Darwin and cannot return unsupported for _OSI("WinXXX") invoked > before invoking _OSI("Darwin"). > > This patch fixes the issues by reverting the wrong support and implementing > the default behavior of _OSI("Darwin")/_OSI("WinXXX") on Apple hardware via > DMI matching. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=92111 > Reported-by: Lukas Wunner > Signed-off-by: Chen Yu > Signed-off-by: Lv Zheng Why don't you add a Fixes tag pointing to the problematic commit?