Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752644AbcDZUyD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Apr 2016 16:54:03 -0400
Received: from mail-yw0-f175.google.com ([209.85.161.175]:33134 "EHLO
	mail-yw0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752310AbcDZUx7 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Apr 2016 16:53:59 -0400
MIME-Version: 1.0
In-Reply-To: <9945516.Q6LYCrkl5z@diego>
References: <1461638206-20473-1-git-send-email-jay.xu@rock-chips.com>
	<1461638206-20473-5-git-send-email-jay.xu@rock-chips.com>
	<9945516.Q6LYCrkl5z@diego>
Date: Tue, 26 Apr 2016 13:53:58 -0700
X-Google-Sender-Auth: gOqtRJkUerHe7nD4KqmPec-BQXY
Message-ID: <CAD=FV=Wgnz-vBo71f3mqFxcOpL7fJX58hXPJ+vk9uHpymqdN5Q@mail.gmail.com>
Subject: Re: [PATCH 4/4] ARM64: dts: rockchip: add dts file for RK3399
 evaluation board
From: Doug Anderson <dianders@chromium.org>
To: =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>
Cc: Jianqun Xu <jay.xu@rock-chips.com>, lintao <lintao@rock-chips.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Tao Huang <huangtao@rock-chips.com>,
        David Riley <davidriley@chromium.org>,
        Julius Werner <jwerner@chromium.org>, smbarber@chromium.org,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1244
Lines: 32

Hi,

On Tue, Apr 26, 2016 at 5:37 AM, Heiko Stübner <heiko@sntech.de> wrote:
>> +     model = "Rockchip RK3399 Evaluation Board";
>> +     compatible = "rockchip,rk3399-evb", "rockchip,rk3399",
>> +                  "google,rk3399evb-rev2", google,rk3399evb-rev1",
>> +                  "google,rk3399evb-rev0" ;
>
> can you check against which compatibles that coreboot really matches?
>
> As we said that the evb changed between rev1 and rev2, I would expect the
> compatible to be something like
>
>         compatible = "rockchip,rk3399-evb",  "google,rk3399evb-rev2",
>                         "rockchip,rk3399";
>
> leaving out the rev1 and rev0

What Heiko suggests seems reasonable to me.

It all depends on what your bootloader is doing and what you guys want
to do.  Chrome OS designs that I've worked on have had board
strappings that you can read a board ID from and that's how the BIOS
(like coreboot) will figure out which board ID it is running on.  I'm
not aware of such strappings on rk3399-evb.  Do they exist?

Of course, even without strappings it's possible to get the bootloader
to work sanely.  You can either define the revision number at build
time or you can store the revision number somewhere non-volatile.


-Doug