Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752705AbcDZV4D (ORCPT ); Tue, 26 Apr 2016 17:56:03 -0400 Received: from merlin.infradead.org ([205.233.59.134]:44806 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbcDZV4B (ORCPT ); Tue, 26 Apr 2016 17:56:01 -0400 Date: Tue, 26 Apr 2016 23:55:36 +0200 From: Peter Zijlstra To: Arnaldo Carvalho de Melo Cc: Brendan Gregg , Arnaldo Carvalho de Melo , Alexei Starovoitov , David Ahern , Frederic Weisbecker , Ingo Molnar , Adrian Hunter , Alexander Shishkin , Alexei Starovoitov , He Kuang , Jiri Olsa , Masami Hiramatsu , Milian Wolff , Namhyung Kim , Stephane Eranian , Thomas Gleixner , Vince Weaver , Wang Nan , Zefan Li , Linux Kernel Mailing List Subject: Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl Message-ID: <20160426215536.GP3430@twins.programming.kicks-ass.net> References: <20160425201750.GD25218@kernel.org> <20160425215947.GA25915@ast-mbp.thefacebook.com> <20160425234138.GA16708@kernel.org> <20160426000724.GA28705@ast-mbp.thefacebook.com> <20160426002928.GB16708@kernel.org> <20160426004358.GA29875@ast-mbp.thefacebook.com> <20160426004747.GC16708@kernel.org> <20160426210500.GK11033@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160426210500.GK11033@kernel.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 23 On Tue, Apr 26, 2016 at 06:05:00PM -0300, Arnaldo Carvalho de Melo wrote: > > I started with max depth = 512, and even that was still truncated, and > > had to profile again at 1024 to capture the full stacks. Seems to ^^^^^^ > > generally match the flame graph I generated with V1, which made me > > want to check that I'm running the new patch, and am: > > > > # grep six_hundred_forty_kb /proc/kallsyms > > ffffffff81c431e0 d six_hundred_forty_kb > > > > I was mucking around and was able to get "corrupted callchain. > > skipping..." errors, but these look to be expected -- that was > > Yeah, thanks for testing! > > And since you talked about userspace without frame pointers, have you > played with '--call-graph lbr'? That seems to be at odds with his requirements; he needs 1024 entries to capture full stacks, LBR is limited to 16/32 or so entries. That's 2 orders of magnitude difference.