Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663AbcD0B6t (ORCPT ); Tue, 26 Apr 2016 21:58:49 -0400 Received: from mail.kernel.org ([198.145.29.136]:51646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbcD0B6r (ORCPT ); Tue, 26 Apr 2016 21:58:47 -0400 Date: Wed, 27 Apr 2016 09:58:36 +0800 From: Shawn Guo To: Dong Aisheng Cc: Lucas Stach , Michael Turquette , Stephen Boyd , "linux-kernel@vger.kernel.org" , Stefan Agner , mingo@redhat.com, "kernel@pengutronix.de" , tglx@linutronix.de, linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] clk: imx: do not sleep if IRQ's are still disabled Message-ID: <20160427015835.GE30692@tiger> References: <1454107764-19876-1-git-send-email-stefan@agner.ch> <20160421034520.GA19965@shlinux2.ap.freescale.net> <20160426012341.GB8870@tiger> <1461663072.7839.17.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 471 Lines: 13 On Tue, Apr 26, 2016 at 07:27:03PM +0800, Dong Aisheng wrote: > Shawn, > What's your suggestion? I think this needs more discussion, and I just dropped Stefan's patch from my tree. We need to firstly understand why this is happening. The .prepare hook is defined to be non-atomic context, and so that we call sleep function in there. We did everything right. Why are we getting the warning? If I'm correct, this warning only happens on i.MX7D. Why is that? Shawn