Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753057AbcD0CBo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Apr 2016 22:01:44 -0400
Received: from mga03.intel.com ([134.134.136.65]:47698 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752485AbcD0CBm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Apr 2016 22:01:42 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,539,1455004800"; 
   d="scan'208";a="953682897"
From: "Zheng, Lv" <lv.zheng@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
CC: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "Brown, Len" <len.brown@intel.com>, Lv Zheng <zetalog@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "Chen, Yu C" <yu.c.chen@intel.com>
Subject: RE: [PATCH 3/4] ACPI / osi: Change default _OSI(Darwin) support
Thread-Topic: [PATCH 3/4] ACPI / osi: Change default _OSI(Darwin) support
Thread-Index: AQHRn48Kt2rDSvX9u0WIN5VTntLBo5+cKvWAgADnBaA=
Date: Wed, 27 Apr 2016 02:01:37 +0000
Message-ID: <1AE640813FDE7649BE1B193DEA596E883BB828E1@SHSMSX101.ccr.corp.intel.com>
References: <cover.1461656216.git.lv.zheng@intel.com>
	<721499bcaa3559f71023c6ab960481564f58f22a.1461656216.git.lv.zheng@intel.com>
 <CAJZ5v0gOY==-PUNcp-5rsp1mrD=V215rUAWmx6LFM7+CgF=8dA@mail.gmail.com>
In-Reply-To: <CAJZ5v0gOY==-PUNcp-5rsp1mrD=V215rUAWmx6LFM7+CgF=8dA@mail.gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzA2NGUwOGYtYjE2ZC00NDMwLThhNTctMjNiNjUzMDE2ODQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJ4WW9QSEcwWjl2V3VPOXBnbnFRYnZMT1F3WHQyenhRKzBxWU1WU3R6WUk9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u3R21mel014075
Content-Length: 1223
Lines: 32

Hi,

> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of
> Rafael J. Wysocki
> Sent: Wednesday, April 27, 2016 4:13 AM
> Subject: Re: [PATCH 3/4] ACPI / osi: Change default _OSI(Darwin) support
> 
> On Tue, Apr 26, 2016 at 9:40 AM, Lv Zheng <lv.zheng@intel.com> wrote:
> > From: Chen Yu <yu.c.chen@intel.com>
> >
> > Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always
> > reports positive value when Apple hardware queries _OSI("Darwin"). However
> > since this implementation places the judgement in runtime, it breaks
> > acpi_osi=!Darwin and cannot return unsupported for _OSI("WinXXX") invoked
> > before invoking _OSI("Darwin").
> >
> > This patch fixes the issues by reverting the wrong support and implementing
> > the default behavior of _OSI("Darwin")/_OSI("WinXXX") on Apple hardware
> via
> > DMI matching.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=92111
> > Reported-by: Lukas Wunner <lukas@wunner.de>
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> 
> Why don't you add a Fixes tag pointing to the problematic commit?
[Lv Zheng] 
OK, I'll help to add it and re-send an UPDATE for this patch.

Thanks
-Lv