Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbcD0CpO (ORCPT ); Tue, 26 Apr 2016 22:45:14 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:52050 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752603AbcD0CpN (ORCPT ); Tue, 26 Apr 2016 22:45:13 -0400 Date: Tue, 26 Apr 2016 22:45:11 -0400 From: Mike Frysinger To: "Dmitry V. Levin" Cc: "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] parisc: fix a bug when syscall number of tracee is __NR_Linux_syscalls Message-ID: <20160427024511.GA5369@vapier.lan> Mail-Followup-To: "Dmitry V. Levin" , "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160427015611.GA23316@altlinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Pcw6Z5YEpa6jVCsn" Content-Disposition: inline In-Reply-To: <20160427015611.GA23316@altlinux.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2224 Lines: 62 --Pcw6Z5YEpa6jVCsn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 27 Apr 2016 04:56, Dmitry V. Levin wrote: > Do not load one entry beyond the end of the syscall table when the > syscall number of a traced process equals to __NR_Linux_syscalls. > Similar bug with regular processes was fixed by commit 3bb457af4fa8 > ("[PARISC] Fix bug when syscall nr is __NR_Linux_syscalls"). >=20 > This bug was found by strace test suite. >=20 > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry V. Levin > --- > arch/parisc/kernel/syscall.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S > index c976ebf..57b4836 100644 > --- a/arch/parisc/kernel/syscall.S > +++ b/arch/parisc/kernel/syscall.S > @@ -344,7 +344,7 @@ tracesys_next: > #endif > =20 > cmpib,COND(=3D),n -1,%r20,tracesys_exit /* seccomp may have returned -1= */ > - comiclr,>>=3D __NR_Linux_syscalls, %r20, %r0 > + comiclr,>> __NR_Linux_syscalls, %r20, %r0 > b,n .Ltracesys_nosys > =20 > LDREGX %r20(%r19), %r19 i've deployd your fix to hake, so feel free to give the tests another run to try and crash the box :). -mike --Pcw6Z5YEpa6jVCsn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXICe3AAoJEEFjO5/oN/WBuygP/1nPmdnppZqXhIOkW6E4dGm/ gUIpQZxjCRs6qaw0ncjkIP/5QYJ780/RIWOmfr0+bFQC6XsDHWXy2+Ub7Tp4eYoT m8nF4T6KYRbPN4qisjExVrPPLgUevV87+bf28dKFPk228Nh+3YwbmxQXIL37A1rv VB2gqDFP7ym/E5w5w/dd8KI2oSJQJk0efegwebA8RCjOgPzeezNv7s/HLZkZazB7 WPJGplwCn8z2HasoxKXlR+jsrHMxFvMp/mINvJwJM4h1XFoOKF0NnEMaINl1MwM7 zyHHWQaj6Fa18mnJwOAShwAjYDw10lJQGwqVcJIFaKnWfxOR9fSTMl03qcEpVBml TFo3/1muz9uq/9ODNuQsZMSV3Ne1HGMKohMMLBm/91TJagh99K672VHxYQkxCXlW pCd6CST0cdAcxBljqudRWO/kVkCScia0fcIBwGvYa2hqWB6Iot2kE9sMUl9n4bp8 qcb6xkgQpx4oa6eyOvsJnbULHn69fW4lFhY7rHfaGZ3fyiWXWn3kH4D8wgRBcVcH YMNsIh1l6O5LP05TqvH+JpqtqA2eb5xauUvx62b/QPuNsxULFU5TGBvAsbGMTRsN 3iMuCOP3AM4ULBtRyQc/emvKhrRce/Ori0o6MYmxXabAN72y3MzMIyJNvYIeSCUm eliconcPfhFlTPpXgCbj =1U7X -----END PGP SIGNATURE----- --Pcw6Z5YEpa6jVCsn--