Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbcD0DMR (ORCPT ); Tue, 26 Apr 2016 23:12:17 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:13241 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbcD0DMQ (ORCPT ); Tue, 26 Apr 2016 23:12:16 -0400 Subject: Re: [PATCH 1/2] bfp tools: Remove expression with no effect To: Florian Fainelli , References: <1461551694-5512-1-git-send-email-f.fainelli@gmail.com> <1461551694-5512-2-git-send-email-f.fainelli@gmail.com> CC: , , From: "Wangnan (F)" Message-ID: <57202DDE.8090200@huawei.com> Date: Wed, 27 Apr 2016 11:11:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1461551694-5512-2-git-send-email-f.fainelli@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.57202E0B.0047,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 9aa4f595106bd2d50784c63129793bef Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 27 On 2016/4/25 10:34, Florian Fainelli wrote: > Assigning "attr" to "attr" does not have any effect, but was caught by > Coverity, so let's remove this. > > Reported-by: coverity (CID 1354720) > Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check") > Signed-off-by: Florian Fainelli > --- > tools/build/feature/test-bpf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c > index b389026839b9..8236df9a46ca 100644 > --- a/tools/build/feature/test-bpf.c > +++ b/tools/build/feature/test-bpf.c > @@ -27,7 +27,6 @@ int main(void) > attr.log_level = 0; > attr.kern_version = 0; > > - attr = attr; > /* > * Test existence of __NR_bpf and BPF_PROG_LOAD. > * This call should fail if we run the testcase. Tested-by: Wang Nan