Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbcD0FdA (ORCPT ); Wed, 27 Apr 2016 01:33:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:5172 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbcD0Fc7 (ORCPT ); Wed, 27 Apr 2016 01:32:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,540,1455004800"; d="asc'?scan'208";a="692937482" From: Felipe Balbi To: Jisheng Zhang , mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yendapally.reddy@broadcom.com, Jisheng Zhang , Maxime Ripard , Mathias Nyman Subject: Re: [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists In-Reply-To: <1461675460-2295-4-git-send-email-jszhang@marvell.com> References: <1461675460-2295-1-git-send-email-jszhang@marvell.com> <1461675460-2295-4-git-send-email-jszhang@marvell.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 27 Apr 2016 08:30:52 +0300 Message-ID: <87mvofpqib.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2154 Lines: 68 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Jisheng Zhang writes: > Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the > usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the > suspend/resume path. This patch fixes this issue by adding missing > usb_phy related calls. Fixes: 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") Cc: # v4.1+ > Signed-off-by: Jisheng Zhang > --- > drivers/usb/host/xhci-plat.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index 9ff89e9..fbd23fd 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -313,6 +313,7 @@ static int xhci_plat_suspend(struct device *dev) > if (ret) > return ret; >=20=20 > + usb_phy_shutdown(xhci->shared_hcd->usb_phy); > clk_disable_unprepare(xhci->clk); >=20=20 > return ret; > @@ -328,6 +329,10 @@ static int xhci_plat_resume(struct device *dev) > if (ret) > return ret; >=20=20 > + ret =3D usb_phy_init(xhci->shared_hcd->usb_phy); > + if (ret) > + return ret; > + > return xhci_resume(xhci, 0); > } =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXIE6NAAoJEIaOsuA1yqREvj8P/2ZhsjEiJufdm/of7VgzQw3s IkOCpsKSRTPdHruxQznEF0EyL3YH0IXTBbsbMk659KXJbMJmUuC941d5mP1+nIA3 trMKGroVgv6yTOoA8N13hgz7HBWueUzLj9OtyNjbtl1U2bMckTMcpwETcQkZJ4Lw UiELEi/wojOVC/SsSqZ3vVcM76JThFl7sXLsBb+zCnybLSzkBueVvD0wnpNZk5wI Dp/SRKkqHMYUyo8+vTsX18UPPANVoJLoZSRg7PxUSImYG0IiKLzCNaMRdx15vJrI Mu2a+KELAgUmnd7/yzPRCIBgX72b2vllcbR4VPYbc9oi2sXrlVw1IHFT943qwstL O82yDZrbRqEHcTrh120imp4FmRNUuq2xN2QF29ZfnIMRwAT03swMEyat6jvd/n+A P3rgapqP6jyUnezVDnwg4d16WAArKo/LlK2Mg6cYsKkQhByrEPA3hoEjZNxiGjvL VRnblcN2kwd2gMEhSG6QjkvamAopMiatEB3wibKHEF/rSxn6cRcW52NG0yU7i1rp UNOwbOn05fw08gK56ar1FIY3ayPC7g6jNrUrZQr+0P0AI+gA5mXjjS6qPAgXNij9 ZW/WhhDRwB8brYvEFYbDiXY/TCusP24T3XqBKvsZlVp1SPOash97jSDAq0l/ujWU RBmNAxKIgcOh30NL06S0 =ht5G -----END PGP SIGNATURE----- --=-=-=--