Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753069AbcD0FnZ (ORCPT ); Wed, 27 Apr 2016 01:43:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:56152 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbcD0FnX (ORCPT ); Wed, 27 Apr 2016 01:43:23 -0400 From: NeilBrown To: Matthew Wilcox , linux-kernel@vger.kernel.org, Andrew Morton Date: Wed, 27 Apr 2016 15:43:11 +1000 Cc: Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Konstantin Khlebnikov , Kirill Shutemov , Jan Kara , Ross Zwisler Subject: Re: [PATCH 02/19] radix-tree: Miscellaneous fixes In-Reply-To: <1460644642-30642-3-git-send-email-willy@linux.intel.com> References: <1460644642-30642-1-git-send-email-willy@linux.intel.com> <1460644642-30642-3-git-send-email-willy@linux.intel.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-suse-linux-gnu) Message-ID: <8760v3wqs0.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 53 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, Apr 15 2016, Matthew Wilcox wrote: > Typos, whitespace, grammar, line length, using the correct types, etc. > > Signed-off-by: Matthew Wilcox > Reviewed-by: Ross Zwisler >=20=20 > -static inline void root_tag_clear(struct radix_tree_root *root, unsigned= int tag) > +static inline void root_tag_clear(struct radix_tree_root *root, unsigned= tag) Changing "unsigned int" to "unsigned" - Bold. > { > root->gfp_mask &=3D (__force gfp_t)~(1 << (tag + __GFP_BITS_SHIFT)); > } > @@ -159,7 +159,7 @@ static inline void root_tag_clear_all(struct radix_tr= ee_root *root) >=20=20 > static inline int root_tag_get(struct radix_tree_root *root, unsigned in= t tag) Not doing it uniformly - Priceless. NeilBrown --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXIFFvAAoJEDnsnt1WYoG5oLcQAMQH/Kn7DGnUpWK6H7pdLKyX T46I00WDGEtG6RAHIP5FMAdMWZgWjxjdnqZOD2RhISDzPSjsMoP9NzjiQ6N0IEYa xRECMxikC1S8/oR2GM8N410qo0rVLhcT+P1zQXOY2SWvvg36sfEfYwsUoJvjVIHG fCV+Xz//qK7PXqwsaPGRoeyQxuufY6yqbC41524FFsaEYdyNIfXcaRr9xbcjQhiz RpO4WUE/8rjixFfFyoP1oe8LqzcL3WTfEti377H1aaeGlOeTr3azTe42I0/nIpAG WmcYTcbCklAO+6hCVZBcz0fho+yTKiEERklVNJ+oxYRroGi+CsPBT0AIz//L5gir 0bhGZz6mK6vEGszrSm04f5kp54qdChDUKd1T0mmUS0ChcCua6JRaXEYTYGq7kNyZ opunAxDw8ftz80hITWyBENFCHW6Z2vJaaaXOMzmK4Cyy3MYTaFVXyFyozU7LkyB9 d8tCOfPHkfRyxq1iulFJQZ1j4F3QSP+10FS8ikGH2WcEhZ/jWrU4uhT2KnSjx9kN MOTFclVATVehwX96cfti94CKm88WzFNSD1PdmrOl1UAoeO1l4t1AOab3M4Qz5g/Q KNpgD7PXfPlwu3bUhsFkQYTdFFonQ+6tCNHgliGQfYu0hhfypSkDIIEiKd/H+mz9 ampP7ANW0rahW5xelkZQ =/93p -----END PGP SIGNATURE----- --=-=-=--