Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbcD0GV2 (ORCPT ); Wed, 27 Apr 2016 02:21:28 -0400 Received: from mga04.intel.com ([192.55.52.120]:15851 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbcD0GV0 (ORCPT ); Wed, 27 Apr 2016 02:21:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,540,1455004800"; d="asc'?scan'208";a="793241361" From: Felipe Balbi To: Jisheng Zhang Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yendapally.reddy@broadcom.com, Maxime Ripard , Mathias Nyman Subject: Re: [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd In-Reply-To: <20160427135946.3b983890@xhacker> References: <1461675460-2295-1-git-send-email-jszhang@marvell.com> <1461675460-2295-3-git-send-email-jszhang@marvell.com> <87potbpqkh.fsf@intel.com> <20160427135946.3b983890@xhacker> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 27 Apr 2016 09:19:16 +0300 Message-ID: <87h9eno9p7.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2471 Lines: 78 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Jisheng Zhang writes: > Dear Felipe, > > On Wed, 27 Apr 2016 08:29:34 +0300 Felipe Balbi wrote: > >> Hi, >>=20 >> (Cc authors and maintainer, otherwise you're patch might be forgotten ;-) > > Thanks a lot for the kind remind. I just run get_maintainer.pl to get the > To and Cc lists. It seems Mathias's email changed, MAINTAINERS need to up= dated. > >>=20 >> Jisheng Zhang writes: >> > Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the >> > usb_phy for usb3, but it attached the usb_phy to incorrect hcd. The=20= =20 >>=20 >> where did you see that's the USB3 phy ? I can't see it. > > Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") says: > > "The Marvell Armada 385 AP needs a dumb phy in order to enable the USB3 V= BUS." That could be a typo. VBUS is defined by the original USB specification and there is only a single VBUS ping for all speeds ;-) > So I think it means USB3 phy. we should ask patch author :-) > Here I have two questions: Per my understanding, usb_phy is deprecated, a= ll > users and new code are encouraged to use generic phy. I think there must > be some special reason commit 7b8ef22ea547 still made use of usb_phy, cou= ld > I know what's the reason? I don't know, maybe author knows > And could the "USB3 VBUS" support be achieved through regulator framework? depends on how the PHY is integrated but, IMO, it should be doable and is probably preferrable. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXIFnkAAoJEIaOsuA1yqREQ8MQAJJOH2OHdX2CPBz/x8780DMu 2UVFOm2bghZus2ElAslxsANTcCJL6zzSARj0deDGmWXsQPeTPTmfxmA1T01kZqUo Z1uC/xQPjHJmWBFvz00OpN2qafFN3JA96zkZjqo0r4qGqVhsvnyRfqM+f6MQ5Fuh Pq9SDmJ0rK3R+2a/PZ7ZxFfeVXMb2Xf6NdaohZ6sQ3W7tMLM8U4V764quyamvckF C7+V2OnkQ31CLJn0WDUBoCANyg6xZVzvCsqFEv8Qj6OcYWlKomW7WRkYkih0/rhR g8s8Cqf9CEcJGtqY4KKGzDrHGuphaXHv8ywuag4uAIzatEqGDuRgmrDSpMTfRQ+q A4kw7q1CRV0DRJUcH1zaaDayLqvnJdEJyD3pI72EPHqX84vuXcjfy9GUkPLeV9vj 08k5aFl8sd5HfYJBGizD3F+bqNGZQPzER/RY26nNSG+AfwKweb++7R7hAgZkDGXP Z0MS/pApW3zICt1TFv4E2XwyZMs/e5R3dPHncL8u+Vmx/KSYFMWF9c5mRkWkQe1g s5NwwBX1QQQVvOuM5SBA1Yc1a25M6LFgAL+W1IVnQHphrNrAaTgPHoSWYeQ+M/hd zluc5kR5s/ABPrTnXZJTJAyp27RrbmvCMvV/ThzzThdCLNRCTdY2ww1WSkXNKpSQ H/00YMrON31QyWzlUsIr =YSQF -----END PGP SIGNATURE----- --=-=-=--