From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Jisheng Zhang <jszhang@marvell.com>, mathias.nyman@linux.intel.com,
        Kishon Vijay Abraham I <kishon@ti.com>,
        thomas.petazzoni@free-electrons.com,
        gregory.clement@free-electrons.com, maxime.ripard@free-electrons.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        yendapally.reddy@broadcom.com
Subject: Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support
In-Reply-To: <20160427144649.67304003@xhacker>
References: <1461675460-2295-1-git-send-email-jszhang@marvell.com> <1461675460-2295-7-git-send-email-jszhang@marvell.com> <87eg9rpq9t.fsf@intel.com> <20160427144649.67304003@xhacker>
User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu)
Date: Wed, 27 Apr 2016 10:21:44 +0300
Message-ID: <874mano6t3.fsf@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2693
Lines: 78

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Jisheng Zhang <jszhang@marvell.com> writes:
>> > +static void xhci_plat_phy_exit(struct usb_hcd *hcd)
>> > +{
>> > +	if (hcd->phy) {
>> > +		phy_power_off(hcd->phy);
>> > +		phy_exit(hcd->phy);
>> > +	} else {
>> > +		usb_phy_shutdown(hcd->usb_phy);
>> > +	}
>> > +}
>> > +
>> >  static int xhci_plat_probe(struct platform_device *pdev)
>> >  {
>> >  	struct device_node	*node =3D pdev->dev.of_node;
>> > @@ -145,6 +177,7 @@ static int xhci_plat_probe(struct platform_device =
*pdev)
>> >  	struct usb_hcd		*hcd;
>> >  	struct clk              *clk;
>> >  	struct usb_phy		*usb_phy;
>> > +	struct phy		*phy;=20=20
>>=20
>> so, one phy driver using USB PHY layer and another using generic PHY
>> layer ? Why ? I think the first thing your series should do would be to
>
> It's different platforms. E.g
> platform A may write the phy driver under usb phy layer, while platform B
> may have generic phy driver.

right, but both APIs should be supported with *two* PHYs for the time being.

> The questions are: when adding phy support to xhci-plat, the generic phy
> has existed for a long time, what's the reason to use the deprecated usb
> phy APIs.

I don't know, ask the author :-) Maybe the PHY driver was already
available on the USB PHY layer ? What we should do is push that PHY
driver to be moved over to generic PHY layer, then we can get rid of USB
PHY layer from xhci-plat.

> And per my check, it's only MVEBU platforms use this support? I'm not sure
> if we could remove usbphy code from xhci-plat first then add generic phy =
then
> adding MVEBU xhci phy support bak with the new code. So Cc mvebu maintain=
ers

First the PHY driver(s) depending on that should be converted over.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJXIGiJAAoJEIaOsuA1yqREbO0P+wZD/bgNNxx8s3yL9W8e5DLx
/1rGAEXb2Fl0+LW7UyRG8cJkmZLPMn8sQFFBjuvRhKu7nXnzL+wXxIHZrsYr8gie
GXBY2MMuJxSVv/suqPSumwoTK0rNPIFhqpMduKn4lhJZFagzopaOxWBnKhShxumG
WIZXtm+OZNCY1PbUkIIOGQrYUpjjm/dPaSXbLorLxvUUtEpvRy2aWpCsitHn0EKX
jTGXaWuk5NsM6otusb9GKQIt6KlxMf+lnFYS5/KSKnqQaHYzgdulpE6pSWJ6Iv+a
lqkI5npBy+L9dGEEVcMcLS5amm1PBj5gdb5B5nj38piN/jUPIHdzyJ88iD9VeAIC
s8g06ab7RtDt+tL0pJFfdrs5Gn5DsnHUS7CiT30CaSwVpG9AzgKmP+rTy2MBqt7T
apx9abX9GTbR1a2qQWhJW3baSzY905loDfYeDD7dR8xLXbTsqD5yE+Xm4q+ROjWH
24+fJ08ohCPSxatFGAKPzROuQiS3nLoanxMW8zz7gfJ0z2cJc7vCvadqP6UEsHvv
TnEsR21zpCeuseWjD5t0UAMJF/uXOBMl3BT1nBuj4lj/7ueFJim0sDYWHrVM3yDt
TyAaGxbInEYgI+GenY7pFn7SgdHA2DfjfxCJkELmdWuoywHMkaHu1Ks+jcOgbKhp
usc9PhsSNnb9pweNDPta
=Rb0T
-----END PGP SIGNATURE-----
--=-=-=--