Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883AbcD0JCO (ORCPT ); Wed, 27 Apr 2016 05:02:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:37800 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbcD0JCL (ORCPT ); Wed, 27 Apr 2016 05:02:11 -0400 Subject: Re: linux-next: build failure after merge of the block tree To: Nicolas Pitre References: <20160426133812.366dc031@canb.auug.org.au> <571F6D59.8040402@suse.cz> <20160427011825.06c64502@canb.auug.org.au> Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Randy Dunlap From: Michal Marek Message-ID: <57208010.7030505@suse.cz> Date: Wed, 27 Apr 2016 11:02:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 39 On 2016-04-26 22:48, Nicolas Pitre wrote: > On Wed, 27 Apr 2016, Stephen Rothwell wrote: > >> Hi Nicolas, >> >> On Tue, 26 Apr 2016 10:40:57 -0400 (EDT) Nicolas Pitre wrote: >>> >>> If you can reproduce this build failure, could you try a make mrproper >>> and attempt it again? I, too, would like to find an explanation and a >>> way to reproduce. >> >> I reset my build tree to commit 9d67df654092 ("Merge remote-tracking >> branch 'block/for-next'") and the build failed with: >> >> ERROR: ".local_clock" [drivers/vhost/vhost_net.ko] undefined! >> ERROR: ".local_clock" [drivers/misc/cxl/cxl.ko] undefined! >> >> :-( >> >> So I did a "make mrproper" and did the build again. >> >> That built correctly. >> > [...] > > OK! After digging and diffing through 750 megabytes of make debug logs > I finally found the explanation. The if_changed directive is useless > against phony targets. > > @Stephen: could you replace the revert with the patch below in your tree? > > @Michal: could you fold the patch below into commit 2441e78b19 in your tree? I prefer not to overwrite the topic branches unless necessary and I wanted to credit Stephen, so I committed your patch with a fabricated commit message and your signoff (since you wanted to fold it into a patch that you had already signed off). Michal