Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753606AbcD0JgP (ORCPT ); Wed, 27 Apr 2016 05:36:15 -0400 Received: from mga04.intel.com ([192.55.52.120]:19703 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbcD0JgN (ORCPT ); Wed, 27 Apr 2016 05:36:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,540,1455004800"; d="asc'?scan'208";a="963693201" From: Felipe Balbi To: Heikki Krogerus , Jisheng Zhang Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yendapally.reddy@broadcom.com Subject: Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support In-Reply-To: <20160427075751.GA3540@kuha.fi.intel.com> References: <1461675460-2295-1-git-send-email-jszhang@marvell.com> <1461675460-2295-7-git-send-email-jszhang@marvell.com> <20160427075751.GA3540@kuha.fi.intel.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 27 Apr 2016 12:34:07 +0300 Message-ID: <87twinmm40.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1952 Lines: 59 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Heikki Krogerus writes: > On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote: >> @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device = *pdev) >> if (HCC_MAX_PSA(xhci->hcc_params) >=3D 4) >> xhci->shared_hcd->can_do_streams =3D 1; >>=20=20 >> + hcd->phy =3D devm_phy_get(&pdev->dev, "usb2-phy"); >> + if (IS_ERR(hcd->phy)) { >> + ret =3D PTR_ERR(hcd->phy); >> + if (ret =3D=3D -EPROBE_DEFER) >> + goto put_usb3_hcd; >> + hcd->phy =3D NULL; >> + } >> + >> + phy =3D devm_phy_get(&pdev->dev, "usb-phy"); > > "usb-phy" for what I understand is the USB3 PHY right? that doesn't appear to be documented anywhere ;-) > I was unable to find any definition for the phy names for example from > Documentation/devicetree/bindings/usb/usb-xhci.txt, so I would say > this needs to be "usb3-phy" and the phy names need to be defined > somewhere. yeah, usb3-phy sounds like a better name. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXIIePAAoJEIaOsuA1yqREvXgQAJm1Qo7141x3cqkF7jBGuNMW cppSxEf0SigdWc3UARgCJYFApKH/NjMtPOOP04HRjl8MuwCbfEGax5grCt73y1/L VmvHX81mWdwJSV5HzIaWLaP8QOC9oHCSyROTzNobimNArdId3YgOj0oII9qT8B5q ydINJ/70JgOd6uUdW9arC+Yj8FimPk8PRxy2pXW43q38P1YLM0jKuYD98f7HmyAg gKCyfH2rnYqC2QS+DwBu7/IdqmvD75NnR8sc2H3YZ2FgnS3EeVdCzm24BY+YU7Io x+SVNBoavcIc+NXeIvVcMtAyXS35niHfqS5Hk4YH8cf9eWK9TB5uA7SA1+zdTQt9 rLPBjOoz9ar6wnYM/XYjT8ZZKtX01URs24Uu6j1AfZDb/ZeOZKj4+7+pOnhF5RiI Ez34mREGZIUaDLthCdDWsGm5V1iYM+uUWf9qplWJD8loOjA8jPrjDlIPcgmzcJXa x0oJKeIIC6VYjUOOCPKPnmsUfT+o03ntvbAhCMAUr8njHY0GMw8ibbG1aZwfYbby iiqc2Q2wIdCrIWmw18hTNwW1WqPZZDKdiYP+Kpxxamytqihk/qJQBNqwiosXvdZc OdYN2kOtJd3UCjr6Aa5RSgFQjAyzgi/Qc87ieqRqulB5dkNY6XlVp5tNdFAXH4qE KidQubGvpojWMngHZkFf =Zq9D -----END PGP SIGNATURE----- --=-=-=--