Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753564AbcD0K1e (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Apr 2016 06:27:34 -0400
Received: from mga11.intel.com ([192.55.52.93]:28517 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751266AbcD0K1d (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Apr 2016 06:27:33 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,541,1455004800"; 
   d="asc'?scan'208";a="953933791"
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jisheng Zhang <jszhang@marvell.com>, mathias.nyman@linux.intel.com,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        yendapally.reddy@broadcom.com
Subject: Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control
In-Reply-To: <20160427095738.GG3217@sirena.org.uk>
References: <1461675460-2295-1-git-send-email-jszhang@marvell.com> <1461675460-2295-8-git-send-email-jszhang@marvell.com> <87bn4vpq7j.fsf@intel.com> <20160427095738.GG3217@sirena.org.uk>
User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu)
Date: Wed, 27 Apr 2016 13:25:27 +0300
Message-ID: <87oa8vmjqg.fsf@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1631
Lines: 49

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Mark Brown <broonie@kernel.org> writes:
> On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote:
>> Jisheng Zhang <jszhang@marvell.com> writes:
>
>> > +	vbus =3D devm_regulator_get(&pdev->dev, "vbus");
>
>> devm_regulator_get_optional() ??
>
> Does USB work without a VBUS?  Unless the answer is yes then I'd expect

<joke> it can, just source VBUS from a lab power supply </joke>

> this to be just a normal regulator_get().

jokes aside, this regulator is optional because not all platforms
require a SW controlled regulator, no ? Will normal regulator_get() give
us a dummy regulator in case it's not listed in DT/ACPI ?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJXIJOYAAoJEIaOsuA1yqREh6QP/2BNnyaQbsXXMGT18/LnintQ
CL/FCIv7Lyl/AyfHNxvmQnGup4UsQmHnMpjccvG256oT3pe1vTx2hWdnw2A7sxpD
Ri/WegsgfniwNmmSv2j24nmRmjomIpF7+R+WcPJKzXRsL+acBJ+k6mtEXlRbyfrH
7qybZLGeg8yxIUuTcsOJTxux3l7C2t4m4ptqugZOoqYgTYE7kgsaM44LaSpzoShc
wHD28OoPtgFK0M0UGvUbLokEOYA99KkndSf3QG5QLYR1aSufP7n5TzXQdOXWkzKz
gYVnhrnd8HdI4Ky9l9k6maS2IapeF4YnxbWlolyh02raFOlaJFKONXVTJOM0YViz
N3Tmlaq/5VI+iS0YOJgkqzXhbj8kvME1hssfMqU5m2TdQRoMvFSAEBwoRu4+M+CQ
Zd39VswfZ672W4psvBwwyNpIFS04+JG2KQDCQHUBG1sA8gPpdxr6B1QIODjfQUjK
vFXVsUKwqUs8WS4SEz1fitTv8lfaWC0cLe5V5pBNfxMJAugM9xMXW0uQNhN/1q/C
/Kzdh1subjaVbHisEO2VBGkLKqkopwvXQZ31DCCzCkp6xwmHmS/5eb5tNRQ+zmg4
c2V2fVBhhZo2mUugGgWBrDkXleY/KB3dk8iKYwO3fV3QXevDxOTR1juaAE1qZEKm
4ZvXrEORDa4c6mrXXBv9
=Rqii
-----END PGP SIGNATURE-----
--=-=-=--