Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753864AbcD0LBM (ORCPT ); Wed, 27 Apr 2016 07:01:12 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:44183 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbcD0LBK (ORCPT ); Wed, 27 Apr 2016 07:01:10 -0400 Subject: Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core To: Jun Li , "stern@rowland.harvard.edu" , "balbi@kernel.org" , "gregkh@linuxfoundation.org" , "peter.chen@freescale.com" References: <1459865117-7032-1-git-send-email-rogerq@ti.com> <1459865117-7032-9-git-send-email-rogerq@ti.com> CC: "dan.j.williams@intel.com" , "jun.li@freescale.com" , "mathias.nyman@linux.intel.com" , "tony@atomide.com" , "Joao.Pinto@synopsys.com" , "abrestic@chromium.org" , "r.baldyga@samsung.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" From: Roger Quadros Message-ID: <57209BE2.7030300@ti.com> Date: Wed, 27 Apr 2016 14:00:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 26 On 27/04/16 13:16, Jun Li wrote: > Hi > >> >> + >> +static struct otg_hcd_ops otg_hcd_intf = { >> + .add = usb_add_hcd, >> + .remove = usb_remove_hcd, >> + .usb_bus_start_enum = usb_bus_start_enum, > > Build break if CONFIG_USB_OTG is not enabled: > > drivers/built-in.o:(.data+0x1db30): undefined reference to `usb_bus_start_enum' > Makefile:948: recipe for target 'vmlinux' failed > make: *** [vmlinux] Error 1 Thanks. Will fix it. cheers, -roger > >> + .usb_control_msg = usb_control_msg, >> + .usb_hub_find_child = usb_hub_find_child, }; >> + >