Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752473AbcD0LUj (ORCPT ); Wed, 27 Apr 2016 07:20:39 -0400 Received: from forward9p.cmail.yandex.net ([87.250.241.194]:33513 "EHLO forward9p.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbcD0LUi (ORCPT ); Wed, 27 Apr 2016 07:20:38 -0400 X-Greylist: delayed 423 seconds by postgrey-1.27 at vger.kernel.org; Wed, 27 Apr 2016 07:20:38 EDT From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Dan Carpenter Cc: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" In-Reply-To: <20160414093548.GG16549@mwanda> References: <20160414093548.GG16549@mwanda> Subject: Re: [patch] w1: silence an uninitialized variable warning MIME-Version: 1.0 Message-Id: <514231461755695@web6g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Wed, 27 Apr 2016 14:14:55 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 24 Hi Dan 14.04.2016, 12:36, "Dan Carpenter" : > If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Looks good to me, please pull it into janitors tree > Signed-off-by: Dan Carpenter Acked-by: Evgeniy Polaykov > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 89a7847..bb34362 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -335,7 +335,7 @@ static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev, > ?????????int tmp; > ?????????struct w1_master *md = dev_to_w1_master(dev); > > - if (kstrtoint(buf, 0, &tmp) == -EINVAL || tmp < 1) > + if (kstrtoint(buf, 0, &tmp) || tmp < 1) > ?????????????????return -EINVAL; > > ?????????mutex_lock(&md->mutex);