Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbcD0LuE (ORCPT ); Wed, 27 Apr 2016 07:50:04 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:39670 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbcD0LuB (ORCPT ); Wed, 27 Apr 2016 07:50:01 -0400 Subject: Re: [PATCH 3/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency To: "J.D. Schroeder" , , , , , , , , , , , , References: <1461693269-19436-1-git-send-email-Linux.HWI@garmin.com> <1461693269-19436-4-git-send-email-Linux.HWI@garmin.com> CC: "J.D. Schroeder" From: Tero Kristo Message-ID: <5720A73B.6050408@ti.com> Date: Wed, 27 Apr 2016 14:49:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461693269-19436-4-git-send-email-Linux.HWI@garmin.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 38 On 26/04/16 20:54, J.D. Schroeder wrote: > From: "J.D. Schroeder" > > This commit updates the OSC_32K_CLK (secure_32k_clk_src_ck) frequency > from the precise 32kHz frequency (i.e., 32.768 kHz) to the more > accurate frequency of ~34.6 kHz. Actual measured frequencies of the > clock vary from board to board anywhere from 34.4 kHz up to 34.8 kHz. Uhm, if you have a board specific, accurate value for this clock, you should update it in the board file itself. This definition is going to be used across all the DRA7 / AM57xx boards, which can very likely have different crystal accuracies. So, NAK. -Tero > > Signed-off-by: J.D. Schroeder > Reviewed-by: Trenton Andres > --- > arch/arm/boot/dts/dra7xx-clocks.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi > index a514fc3..4501140 100644 > --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi > +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi > @@ -95,7 +95,7 @@ > secure_32k_clk_src_ck: secure_32k_clk_src_ck { > #clock-cells = <0>; > compatible = "fixed-clock"; > - clock-frequency = <32768>; > + clock-frequency = <34600>; /* approximate frequency */ > }; > > virt_12000000_ck: virt_12000000_ck { >