Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S263268AbTCYUDH>; Tue, 25 Mar 2003 15:03:07 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S263270AbTCYUDH>; Tue, 25 Mar 2003 15:03:07 -0500
Received: from phoenix.mvhi.com ([195.224.96.167]:55566 "EHLO
	phoenix.infradead.org") by vger.kernel.org with ESMTP
	id <S263268AbTCYUDE>; Tue, 25 Mar 2003 15:03:04 -0500
Date: Tue, 25 Mar 2003 20:14:11 +0000 (GMT)
From: James Simmons <jsimmons@infradead.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
cc: Linux Fbdev development list 
	<linux-fbdev-devel@lists.sourceforge.net>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BK FBDEV] A few more updates.
In-Reply-To: <1048623026.10476.17.camel@zion.wanadoo.fr>
Message-ID: <Pine.LNX.4.44.0303252011360.6228-100000@phoenix.infradead.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1274
Lines: 30


> > > Well, actually, creating a workqueue would be overhead since
> > > it involves one kernel thread per CPU. After more thinking &
> > > discussion, I beleive you shall rather use keventd existing
> > > workqueue (schedule_work() will do that)
> > 
> > Done. Can you look over this patch and test it. I tested it and it worked 
> > fine.
> 
> I don't have a test config at hand right now. The patch looks better,
> though you didn't remove the spinlock and replace it with some
> "softer" sync. primitives.

I didn't get around to removing the spinlock. That is next on the list.
I just wanted to fix the big problem.  

> Note that if fbcon is ever to be rmmod'ed, you need to properly
> remove the timer and make sure all pending work queues have completed
> (and make sure the timer won't be re-scheduled by one).

Note support for rmmod fbcon is incomplete. The function giveup_console is 
really sad but none one ever imagine that the console system would become 
powerful enough to switch from one driver to another. 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/