Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752927AbcD0NUK (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Apr 2016 09:20:10 -0400
Received: from mail.kernel.org ([198.145.29.136]:37708 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752756AbcD0NUI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Apr 2016 09:20:08 -0400
Date: Wed, 27 Apr 2016 10:20:02 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Ingo Molnar <mingo@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Alexei Starovoitov <ast@kernel.org>, He Kuang <hekuang@huawei.com>,
        Jiri Olsa <jolsa@redhat.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        Milian Wolff <milian.wolff@kdab.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Vince Weaver <vincent.weaver@maine.edu>,
        Wang Nan <wangnan0@huawei.com>, Zefan Li <lizefan@huawei.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth
 via sysctl
Message-ID: <20160427132002.GO11033@kernel.org>
References: <20160425201750.GD25218@kernel.org>
 <20160425215947.GA25915@ast-mbp.thefacebook.com>
 <20160425234138.GA16708@kernel.org>
 <20160426000724.GA28705@ast-mbp.thefacebook.com>
 <20160426002928.GB16708@kernel.org>
 <20160426004358.GA29875@ast-mbp.thefacebook.com>
 <20160426004747.GC16708@kernel.org>
 <CAE40pdeG-TrtBNS10XDQx2ynFqRAhbgENrU7g-_3Oqho047E0A@mail.gmail.com>
 <20160426163321.GI11033@kernel.org>
 <571F9B28.8040001@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <571F9B28.8040001@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 724
Lines: 21

Em Tue, Apr 26, 2016 at 10:45:28AM -0600, David Ahern escreveu:
> On 4/26/16 10:33 AM, Arnaldo Carvalho de Melo wrote:
> >So, for completeness, further testing it to see how far it goes on a 8GB
> >machine I got:
> >
> >[root@emilia ~]# echo 131100 > /proc/sys/kernel/perf_event_max_stack
> >[root@emilia ~]# perf record -g ls
> >Error:
> >The sys_perf_event_open() syscall returned with 12 (Cannot allocate memory) for event (cycles).
> >/bin/dmesg may provide additional information.
> >No CONFIG_PERF_EVENTS=y kernel support configured?
> 
> I thought we fixed up the last line to not display for errors like this.

For most cases, yes.
 
> How about adding ENOMEM case to perf_evsel__open_strerror?

I'll do.

- Arnaldo