Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbcD0Nqn (ORCPT ); Wed, 27 Apr 2016 09:46:43 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:36077 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbcD0Nql (ORCPT ); Wed, 27 Apr 2016 09:46:41 -0400 Date: Wed, 27 Apr 2016 09:46:37 -0400 (EDT) From: Nicolas Pitre To: Michal Marek cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Randy Dunlap Subject: Re: linux-next: build failure after merge of the block tree In-Reply-To: <57208010.7030505@suse.cz> Message-ID: References: <20160426133812.366dc031@canb.auug.org.au> <571F6D59.8040402@suse.cz> <20160427011825.06c64502@canb.auug.org.au> <57208010.7030505@suse.cz> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 44 On Wed, 27 Apr 2016, Michal Marek wrote: > On 2016-04-26 22:48, Nicolas Pitre wrote: > > On Wed, 27 Apr 2016, Stephen Rothwell wrote: > > > >> Hi Nicolas, > >> > >> On Tue, 26 Apr 2016 10:40:57 -0400 (EDT) Nicolas Pitre wrote: > >>> > >>> If you can reproduce this build failure, could you try a make mrproper > >>> and attempt it again? I, too, would like to find an explanation and a > >>> way to reproduce. > >> > >> I reset my build tree to commit 9d67df654092 ("Merge remote-tracking > >> branch 'block/for-next'") and the build failed with: > >> > >> ERROR: ".local_clock" [drivers/vhost/vhost_net.ko] undefined! > >> ERROR: ".local_clock" [drivers/misc/cxl/cxl.ko] undefined! > >> > >> :-( > >> > >> So I did a "make mrproper" and did the build again. > >> > >> That built correctly. > >> > > [...] > > > > OK! After digging and diffing through 750 megabytes of make debug logs > > I finally found the explanation. The if_changed directive is useless > > against phony targets. > > > > @Stephen: could you replace the revert with the patch below in your tree? > > > > @Michal: could you fold the patch below into commit 2441e78b19 in your tree? > > I prefer not to overwrite the topic branches unless necessary and I > wanted to credit Stephen, so I committed your patch with a fabricated > commit message and your signoff (since you wanted to fold it into a > patch that you had already signed off). Fine with me. Nicolas