Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752990AbcD0N7p (ORCPT ); Wed, 27 Apr 2016 09:59:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26977 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752882AbcD0N7l (ORCPT ); Wed, 27 Apr 2016 09:59:41 -0400 Date: Wed, 27 Apr 2016 16:58:36 +0300 From: Dan Carpenter To: YU Bo Cc: Patard , Kroah-Hartman , Sim , Goyal , Barnes , Sachdeva , Frederick , Ravichandran , yuzibode@126.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning Message-ID: <20160427135836.GM4298@mwanda> References: <20160427132736.GA19002@yubo-2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160427132736.GA19002@yubo-2> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 26 On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote: > Fixed checkpatch.pl's warning 'Comparisons should place the constant on > the right side of the test' > > Signed-off-by: YU Bo > --- > drivers/staging/xgifb/vb_setmode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c > index 50c8ea4f5ab7..8bf253c224ad 100644 > --- a/drivers/staging/xgifb/vb_setmode.c > +++ b/drivers/staging/xgifb/vb_setmode.c > @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table, > if (pVBInfo->LCDInfo & EnableScalingLCD) > tempdx &= (~PanelResInfo); > > - if (table[i].PANELID == tempdx) { > + if (tempdx == table[i].PANELID) { I don't understand why checkpatch is complaining about this one... It seems like a false positive. Maybe it's because .PANELID is a rubbish variable name. regards, dan carpetner