Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515AbcD0ODY (ORCPT ); Wed, 27 Apr 2016 10:03:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30480 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbcD0ODX (ORCPT ); Wed, 27 Apr 2016 10:03:23 -0400 Subject: Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests To: David Vrabel , Juergen Gross , Stefano Stabellini , Konrad Rzeszutek Wilk References: <57189880.6030102@suse.com> <572047D3.1000002@suse.com> <572087E0.4030708@citrix.com> <5720C0E2.8080904@oracle.com> <5720C14A.1070707@citrix.com> Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <5720C6A8.7090806@oracle.com> Date: Wed, 27 Apr 2016 10:03:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <5720C14A.1070707@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 446 Lines: 16 On 04/27/2016 09:40 AM, David Vrabel wrote: > On 27/04/16 14:38, Boris Ostrovsky wrote: >> int xen_nr_legacy_irqs() >> { >> if (xen_hvm_domain()) >> return nr_legacy_irqs(); >> if (xen_initial_domain()) >> return NR_IRQS_LEGACY; >> return 0; >> } > Yeah, if that does the right thing... I think it will break xen_allocate_irq_gsi() again, unless we check for HVM domain explicitly. Which would be ugly. -boris