Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbcD0OdI (ORCPT ); Wed, 27 Apr 2016 10:33:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34466 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752826AbcD0OdF (ORCPT ); Wed, 27 Apr 2016 10:33:05 -0400 Date: Wed, 27 Apr 2016 11:33:02 -0300 From: Arnaldo Carvalho de Melo To: "Wangnan (F)" Cc: Florian Fainelli , linux-kernel@vger.kernel.org, ast@kernel.org, jolsa@kernel.org Subject: Re: [PATCH 1/2] bfp tools: Remove expression with no effect Message-ID: <20160427143302.GB2535@redhat.com> References: <1461551694-5512-1-git-send-email-f.fainelli@gmail.com> <1461551694-5512-2-git-send-email-f.fainelli@gmail.com> <57202DDE.8090200@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57202DDE.8090200@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 27 Apr 2016 14:33:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 29 Em Wed, Apr 27, 2016 at 11:11:26AM +0800, Wangnan (F) escreveu: > > > On 2016/4/25 10:34, Florian Fainelli wrote: > >Assigning "attr" to "attr" does not have any effect, but was caught by > >Coverity, so let's remove this. > > > >Reported-by: coverity (CID 1354720) > >Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check") > >Signed-off-by: Florian Fainelli > >--- > > tools/build/feature/test-bpf.c | 1 - > > 1 file changed, 1 deletion(-) > > > >diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c > >index b389026839b9..8236df9a46ca 100644 > >--- a/tools/build/feature/test-bpf.c > >+++ b/tools/build/feature/test-bpf.c > >@@ -27,7 +27,6 @@ int main(void) > > attr.log_level = 0; > > attr.kern_version = 0; > >- attr = attr; > > /* > > * Test existence of __NR_bpf and BPF_PROG_LOAD. > > * This call should fail if we run the testcase. > > Tested-by: Wang Nan Applied