Date: Wed, 27 Apr 2016 17:34:30 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: David Woodhouse <dwmw2@infradead.org>, Kevin Wolf <kwolf@redhat.com>,
        Wei Liu <wei.liu2@citrix.com>, Andy Lutomirski <luto@kernel.org>,
        qemu-block@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>,
        Jason Wang <jasowang@redhat.com>,
        Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        qemu-devel@nongnu.org, peterx@redhat.com, linux-kernel@vger.kernel.org,
        Amit Shah <amit.shah@redhat.com>, iommu@lists.linux-foundation.org,
        Stefan Hajnoczi <stefanha@redhat.com>, kvm@vger.kernel.org,
        cornelia.huck@de.ibm.com, pbonzini@redhat.com,
        virtualization@lists.linux-foundation.org,
        Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH V2 RFC] fixup! virtio: convert to use DMA api
Message-ID: <20160427172630-mutt-send-email-mst@redhat.com>
References: <1461245745-6710-1-git-send-email-mst@redhat.com>
 <20160421135416.GE11775@citrix.com>
 <1461759501.118304.149.camel@infradead.org>
 <20160427153345-mutt-send-email-mst@redhat.com>
 <20160427142331.GH17926@8bytes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160427142331.GH17926@8bytes.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1394
Lines: 38

On Wed, Apr 27, 2016 at 04:23:32PM +0200, Joerg Roedel wrote:
> On Wed, Apr 27, 2016 at 04:37:04PM +0300, Michael S. Tsirkin wrote:
> > One correction: it's a feature of the device in the system.
> > There could be a mix of devices bypassing and not
> > bypassing the IOMMU.
> 
> No, it really is not. A device can't chose to bypass the IOMMU. But the
> IOMMU can chose to let the device bypass.

QEMU can choose to bypass IOMMU for one device and not the other.
IOMMU in QEMU isn't involved when it's bypassed.

> So any fix here belongs
> into the platform/iommu code too and not into some driver.

Fine but this is beside the point. Almost all virtio devices
bypass IOMMU and what this patch does is create a way
to detect devices that don't. This code can maybe go into
platform.

> > Sounds good. And a way to detect appropriate devices could
> > be by looking at the feature flag, perhaps?
> 
> Again, no! The way to detect that is to look into the iommu description
> structures provided by the firmware. They provide everything necessary
> to tell the iommu code which devices are not translated.
> 
> 
> 
> 	Joerg

It would be easy if they did but they don't do this on all systems.
In particular the idea for firmware interface was clearly
that a given bus either is connected through IOMMU or bypassing it.
Whether virtio bypasses the iommu is unrelated to the bus it's on.

-- 
MST