Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbcD0Ofn (ORCPT ); Wed, 27 Apr 2016 10:35:43 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:44822 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbcD0Ofk (ORCPT ); Wed, 27 Apr 2016 10:35:40 -0400 Subject: Re: [PATCH v6 11/12] usb: core: hub: Notify OTG fsm when A device sets b_hnp_enable To: Peter Chen References: <1459865117-7032-1-git-send-email-rogerq@ti.com> <1459865117-7032-12-git-send-email-rogerq@ti.com> <20160418070842.GC4477@shlinux2.ap.freescale.net> CC: , , , , , , , , , , , , , From: Roger Quadros Message-ID: <5720CE23.7050305@ti.com> Date: Wed, 27 Apr 2016 17:35:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160418070842.GC4477@shlinux2.ap.freescale.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2862 Lines: 86 On 18/04/16 10:08, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:16PM +0300, Roger Quadros wrote: >> This is the a_set_b_hnp_enable flag in the OTG state machine >> diagram and must be set when the A-Host has successfully set >> the b_hnp_enable feature of the OTG-B-Peripheral attached to it. >> >> When this bit changes we kick our OTG FSM to make note of the >> change and act accordingly. > > Since we have still not added fsm.a_set_b_hnp_en in OTG FSM, and this > patch set is mainly for DRD, would you please move out this patch from > this set? Sure. cheers, -roger > >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/core/hub.c | 17 +++++++++++++++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c >> index 38cc4ba..27e3b4c 100644 >> --- a/drivers/usb/core/hub.c >> +++ b/drivers/usb/core/hub.c >> @@ -2273,6 +2273,7 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> && udev->parent == udev->bus->root_hub) { >> struct usb_otg_descriptor *desc = NULL; >> struct usb_bus *bus = udev->bus; >> + struct usb_hcd *hcd = bus_to_hcd(bus); >> unsigned port1 = udev->portnum; >> >> /* descriptor may appear anywhere in config */ >> @@ -2302,6 +2303,9 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> dev_err(&udev->dev, "can't set HNP mode: %d\n", >> err); >> bus->b_hnp_enable = 0; >> + } else { >> + /* notify OTG fsm about a_set_b_hnp_enable */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> } >> } else if (desc->bLength == sizeof >> (struct usb_otg_descriptor)) { >> @@ -2312,10 +2316,14 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> USB_DEVICE_A_ALT_HNP_SUPPORT, >> 0, NULL, 0, >> USB_CTRL_SET_TIMEOUT); >> - if (err < 0) >> + if (err < 0) { >> dev_err(&udev->dev, >> "set a_alt_hnp_support failed: %d\n", >> err); >> + } else { >> + /* notify OTG fsm about a_set_b_hnp_enable */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> + } >> } >> } >> #endif >> @@ -4355,8 +4363,13 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1, >> */ >> if (!hdev->parent) { >> delay = HUB_ROOT_RESET_TIME; >> - if (port1 == hdev->bus->otg_port) >> + if (port1 == hdev->bus->otg_port) { >> hdev->bus->b_hnp_enable = 0; >> +#ifdef CONFIG_USB_OTG >> + /* notify OTG fsm about a_set_b_hnp_enable change */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> +#endif >> + } >> } >> >> /* Some low speed devices have problems with the quick delay, so */ >> -- >> 2.5.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >