Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753071AbcD0O4h (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Apr 2016 10:56:37 -0400
Received: from 8bytes.org ([81.169.241.247]:38671 "EHLO theia.8bytes.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752936AbcD0O4e (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Apr 2016 10:56:34 -0400
Date: Wed, 27 Apr 2016 16:56:32 +0200
From: Joerg Roedel <joro@8bytes.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>, Kevin Wolf <kwolf@redhat.com>,
        Wei Liu <wei.liu2@citrix.com>, Andy Lutomirski <luto@kernel.org>,
        qemu-block@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>,
        Jason Wang <jasowang@redhat.com>,
        Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        qemu-devel@nongnu.org, peterx@redhat.com, linux-kernel@vger.kernel.org,
        Amit Shah <amit.shah@redhat.com>, iommu@lists.linux-foundation.org,
        Stefan Hajnoczi <stefanha@redhat.com>, kvm@vger.kernel.org,
        cornelia.huck@de.ibm.com, pbonzini@redhat.com,
        virtualization@lists.linux-foundation.org,
        Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH V2 RFC] fixup! virtio: convert to use DMA api
Message-ID: <20160427145632.GI17926@8bytes.org>
References: <1461245745-6710-1-git-send-email-mst@redhat.com>
 <20160421135416.GE11775@citrix.com>
 <1461759501.118304.149.camel@infradead.org>
 <20160427153345-mutt-send-email-mst@redhat.com>
 <20160427142331.GH17926@8bytes.org>
 <20160427172630-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160427172630-mutt-send-email-mst@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 832
Lines: 23

On Wed, Apr 27, 2016 at 05:34:30PM +0300, Michael S. Tsirkin wrote:
> On Wed, Apr 27, 2016 at 04:23:32PM +0200, Joerg Roedel wrote:

> QEMU can choose to bypass IOMMU for one device and not the other.
> IOMMU in QEMU isn't involved when it's bypassed.

And it is QEMU's task to tell the OS, right? And the correct way to do
this is via the firmware ACPI tables.

> Fine but this is beside the point. Almost all virtio devices
> bypass IOMMU and what this patch does is create a way
> to detect devices that don't. This code can maybe go into
> platform.

Again, the way to detect this is in platform code must not be device
specific. This is what the DMAR and IVRS tables on x86 are for.

When there is no way to do this in the firmware (or there is no firmware
at all), we have to do a quirk in the platform code for it.



	Joerg