Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753026AbcD0PJS (ORCPT ); Wed, 27 Apr 2016 11:09:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45539 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbcD0PJQ (ORCPT ); Wed, 27 Apr 2016 11:09:16 -0400 Date: Wed, 27 Apr 2016 17:09:13 +0200 From: Karel Zak To: Gwendal Grignou Cc: Davidlohr Bueso , "Elliott, Robert (Persistent Memory)" , Julius Werner , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , Doug Anderson Subject: Re: [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive Message-ID: <20160427150913.m2vvhtriq27u65tk@ws.net.home> References: <1461632806-5946-1-git-send-email-jwerner@chromium.org> <20160426102014.o7k77uzi32h73y3b@ws.net.home> <20160426183353.GB16601@linux-uzut.site> <94D0CD8314A33A4D9D801C0FE68B402963904365@G4W3296.americas.hpqcorp.net> <20160426211547.GC16601@linux-uzut.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 27 Apr 2016 15:09:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 944 Lines: 24 On Tue, Apr 26, 2016 at 02:51:01PM -0700, Gwendal Grignou wrote: > Julius and I were looking at the code when we spotted the issue. > > As Julius said, "just pass a boot param", is not easy on certain > machines, like phone. It is not user friendly either. > The system won't boot at all, a typical user will have to do a full > reinstall to fix the error. And how typical user will fix the problem with corrupted primary header after successful boot? I mean, use alternative header (without force_gpt) is a good idea if we know that user will not ignore the problem. The current solution is to force user to do anything. It would be nice to have support for this issue in userspace and switch for example to single user mode, or so... I'm also have doubts that printk() is the best way how to report this issue to userspace if we want to trigger any action :-) Karel -- Karel Zak http://karelzak.blogspot.com